Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8296275: Write a test to verify setAccelerator method of JMenuItem #1825

Conversation

SoniaZaldana
Copy link
Member

@SoniaZaldana SoniaZaldana commented Oct 3, 2023

Hi all,

This pull request contains a backport of commit b005013a from the openjdk/jdk repository.

The commit being backported was authored by Naveen Narayanan on 21 Dec 2022 and was reviewed by Manukumar V S and Alexey Ivanov.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8296275 needs maintainer approval

Issue

  • JDK-8296275: Write a test to verify setAccelerator method of JMenuItem (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1825/head:pull/1825
$ git checkout pull/1825

Update a local copy of the PR:
$ git checkout pull/1825
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1825/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1825

View PR using the GUI difftool:
$ git pr show -t 1825

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1825.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2023

👋 Welcome back szaldana! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b005013a0015656b7f6ccc26f8a13c44d61f77b9 8296275: Write a test to verify setAccelerator method of JMenuItem Oct 3, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

⚠️ @SoniaZaldana This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 3, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 3, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@SoniaZaldana usage: /approval [<id>] (request|cancel) [<text>]

@SoniaZaldana
Copy link
Member Author

/approval request "Backporting this for parity with 17.0.7-oracle. Low risk as it only adds an additional test case. Patch applies cleanly to 17u."

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@SoniaZaldana
8296275: The approval request has been updated successfully.

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@SoniaZaldana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8296275: Write a test to verify setAccelerator  method of JMenuItem

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 72 new commits pushed to the master branch:

  • 18d61ea: 8041447: Test javax/swing/dnd/7171812/bug7171812.java fails with java.lang.RuntimeException: Test failed, scroll on drag doesn't work
  • 7c26fd8: 8297640: Increase buffer size for buf (insert_features_names) in Abstract_VM_Version::insert_features_names
  • c17878a: 8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed
  • fa42a3e: 8317705: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-ppc64le and aix due to JDK-8248691
  • 8a92a65: 8317706: Exclude java/awt/Graphics2D/DrawString/RotTransText.java on linux
  • c8c1c6a: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
  • 8853be6: 8316906: Clarify TLABWasteTargetPercent flag
  • 179c60f: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • baf717f: 8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI
  • a81b088: 8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()"
  • ... and 62 more: https://git.openjdk.org/jdk17u-dev/compare/e7fc89db52a1ca4ce4c347612b19b8054b1c8d76...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 16, 2023
@SoniaZaldana
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@SoniaZaldana
Your change (at version c77783b) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 17, 2023

Hi @SoniaZaldana,
this was here twice, please close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored
2 participants