Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312440: assert(cast != nullptr) failed: must have added a cast to pin the node #1828

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 4, 2023

I backport this for parity with 17.0.10-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312440 needs maintainer approval

Issue

  • JDK-8312440: assert(cast != nullptr) failed: must have added a cast to pin the node (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1828/head:pull/1828
$ git checkout pull/1828

Update a local copy of the PR:
$ git checkout pull/1828
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1828/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1828

View PR using the GUI difftool:
$ git pr show -t 1828

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1828.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 4, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into pr/1827 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 01e135c91018a41800c2df534b1d6dbd396adbf4 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 4, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 4, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk-notifier openjdk-notifier bot changed the base branch from pr/1827 to master October 6, 2023 07:20
@openjdk-notifier
Copy link

The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork:

git checkout goetz_backport_8312440
git fetch https://git.openjdk.org/jdk17u-dev.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot removed the clean label Oct 6, 2023
@openjdk openjdk bot added the clean label Oct 6, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312440: assert(cast != nullptr) failed: must have added a cast to pin the node

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 6, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 6, 2023

Going to push as commit 7f9b92c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 6, 2023
@openjdk openjdk bot closed this Oct 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 6, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

@GoeLin Pushed as commit 7f9b92c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8312440 branch October 6, 2023 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant