Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files #1840

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 5, 2023

I backport this for parity with 17.0.10-oracle.

Resolved Copyright, will mark as clean.

I also added an import to make it compile.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8308116 needs maintainer approval

Issue

  • JDK-8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1840/head:pull/1840
$ git checkout pull/1840

Update a local copy of the PR:
$ git checkout pull/1840
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1840/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1840

View PR using the GUI difftool:
$ git pr show -t 1840

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1840.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e9320f31dcc4ff5197e8c3bca504a7d5c1a9035e 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 5, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 5, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 6, 2023

Pre-submit failure: code not Java 17.

@GoeLin GoeLin marked this pull request as draft October 6, 2023 16:34
@openjdk openjdk bot removed the rfr Pull request is ready for review label Oct 6, 2023
@openjdk openjdk bot removed the clean label Oct 7, 2023
@GoeLin GoeLin marked this pull request as ready for review October 7, 2023 11:06
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 7, 2023
Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk openjdk bot added the approval label Oct 9, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 66baa03: 8272998: ImageIO.read() throws incorrect exception type
  • a393f25: 8303607: SunMSCAPI provider leaks memory and keys
  • d7e22e8: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
  • 056ba2d: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
  • 3f29f1e: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • 6a0dfaf: 8308223: failure handler missed jcmd.vm.info command
  • aaa6962: 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN"
  • c00d445: 8317121: vector_masked_load instruction is moved too early after JDK-8286941
  • 18fd988: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation
  • adef8e4: 8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 10, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 11, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

Going to push as commit d00e1a3.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 5e0be48: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates
  • 92398a6: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"
  • a387205: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
  • 0a4c423: 8287596: Reorg jdk.test.lib.util.ForceGC
  • ec6f129: 8273921: Refactor NSK/JDI tests to create thread using factory
  • 8e4f66a: 8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads
  • 943ee59: 8287671: Adjust ForceGC to invoke System::gc fewer times for negative case
  • e71a980: 8266593: vmTestbase/nsk/jvmti/PopFrame/popframe011 fails with "assert(java_thread == _state->get_thread()) failed: Must be"
  • 66baa03: 8272998: ImageIO.read() throws incorrect exception type
  • a393f25: 8303607: SunMSCAPI provider leaks memory and keys
  • ... and 8 more: https://git.openjdk.org/jdk17u-dev/compare/9f384e76973922b6aa758ed7dc4363b139b2b03f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2023
@openjdk openjdk bot closed this Oct 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@GoeLin Pushed as commit d00e1a3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8308116 branch October 11, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants