-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8303607: SunMSCAPI provider leaks memory and keys #1848
Conversation
👋 Welcome back macarte! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@macarte This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
/sponsor |
Going to push as commit a393f25.
Your commit was automatically rebased without conflicts. |
@phohensee @macarte Pushed as commit a393f25. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport c51d40cfebe793b2e979db0f2d91ac3b136311bb
Backporting this to 17 as the issue is still relevant; passes tier1 tests and the fix has been verified in 17/windows
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1848/head:pull/1848
$ git checkout pull/1848
Update a local copy of the PR:
$ git checkout pull/1848
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1848/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1848
View PR using the GUI difftool:
$ git pr show -t 1848
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1848.diff
Webrev
Link to Webrev Comment