Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303607: SunMSCAPI provider leaks memory and keys #1848

Closed
wants to merge 1 commit into from

Conversation

macarte
Copy link
Contributor

@macarte macarte commented Oct 5, 2023

Backport c51d40cfebe793b2e979db0f2d91ac3b136311bb

Backporting this to 17 as the issue is still relevant; passes tier1 tests and the fix has been verified in 17/windows


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8303607 needs maintainer approval

Issue

  • JDK-8303607: SunMSCAPI provider leaks memory and keys (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1848/head:pull/1848
$ git checkout pull/1848

Update a local copy of the PR:
$ git checkout pull/1848
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1848/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1848

View PR using the GUI difftool:
$ git pr show -t 1848

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1848.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 5, 2023

👋 Welcome back macarte! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8303607 8303607: SunMSCAPI provider leaks memory and keys Oct 5, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 5, 2023
@macarte macarte changed the title 8303607: SunMSCAPI provider leaks memory and keys Backport c51d40cfebe793b2e979db0f2d91ac3b136311bb Oct 5, 2023
@openjdk openjdk bot changed the title Backport c51d40cfebe793b2e979db0f2d91ac3b136311bb 8303607: SunMSCAPI provider leaks memory and keys Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 5, 2023

⚠️ @macarte This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented Oct 5, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@macarte This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303607: SunMSCAPI provider leaks memory and keys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 5, 2023
@macarte
Copy link
Contributor Author

macarte commented Oct 5, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 5, 2023
@openjdk
Copy link

openjdk bot commented Oct 5, 2023

@macarte
Your change (at version 99db2e9) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 9, 2023

Going to push as commit a393f25.
Since your change was applied there have been 22 commits pushed to the master branch:

  • d7e22e8: 8315683: Parallelize java/util/concurrent/tck/JSR166TestCase.java
  • 056ba2d: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
  • 3f29f1e: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • 6a0dfaf: 8308223: failure handler missed jcmd.vm.info command
  • aaa6962: 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN"
  • c00d445: 8317121: vector_masked_load instruction is moved too early after JDK-8286941
  • 18fd988: 8298868: Update EngineCloseOnAlert.java for changes to TLS implementation
  • adef8e4: 8291550: RISC-V: jdk uses misaligned memory access when AvoidUnalignedAccess enabled
  • 9f384e7: 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors
  • 8314149: 8315606: Open source few swing text/html tests
  • ... and 12 more: https://git.openjdk.org/jdk17u-dev/compare/bf2d133f4a8c99249763a614401c9f08dd865535...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 9, 2023
@openjdk openjdk bot closed this Oct 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 9, 2023
@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@phohensee @macarte Pushed as commit a393f25.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants