Skip to content

Conversation

@Ilyagavrilin
Copy link

@Ilyagavrilin Ilyagavrilin commented Oct 6, 2023

Hi all,

This pull request contains a backport of commit 4726960f from the openjdk/jdk repository.
This feature already backported to openjdk/jdk21u, commit with backport:
915892d

The commit being backported was authored by Antonios Printezis on 7 Aug 2023 and was reviewed by Ludovic Henry and Fei Yang.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313779 needs maintainer approval

Issue

  • JDK-8313779: RISC-V: use andn / orn in the MD5 instrinsic (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1850/head:pull/1850
$ git checkout pull/1850

Update a local copy of the PR:
$ git checkout pull/1850
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1850/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1850

View PR using the GUI difftool:
$ git pr show -t 1850

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1850.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2023

👋 Welcome back igavrilin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4726960fcdc9489fb8f9c7e1a100828f1347c30c 8313779: RISC-V: use andn / orn in the MD5 instrinsic Oct 6, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 6, 2023
@openjdk
Copy link

openjdk bot commented Oct 6, 2023

⚠️ @Ilyagavrilin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 6, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2023

Webrevs

@Ilyagavrilin
Copy link
Author

/approval request I would like to backport this into jdk17u-dev; Applies clean, low-risk, risc-v only change, improves md5 implementation (backported to jdk17u-dev), already backported to jdk21u. Testing: tier1/hotspot:tier2 on risc-v board

@openjdk
Copy link

openjdk bot commented Oct 7, 2023

@Ilyagavrilin
8313779: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 7, 2023
@openjdk
Copy link

openjdk bot commented Oct 8, 2023

@Ilyagavrilin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313779: RISC-V: use andn / orn in the MD5 instrinsic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • 8853be6: 8316906: Clarify TLABWasteTargetPercent flag
  • 179c60f: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • baf717f: 8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI
  • a81b088: 8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()"
  • d00e1a3: 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files
  • 5e0be48: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates
  • 92398a6: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"
  • a387205: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
  • 0a4c423: 8287596: Reorg jdk.test.lib.util.ForceGC
  • ec6f129: 8273921: Refactor NSK/JDI tests to create thread using factory
  • ... and 31 more: https://git.openjdk.org/jdk17u-dev/compare/f1c55d2e7ce16223801c55eb872ef7fa055faabf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 8, 2023
@Ilyagavrilin
Copy link
Author

/integrate

@VladimirKempik
Copy link

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@Ilyagavrilin
Your change (at version e7dd103) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

Going to push as commit c8c1c6a.
Since your change was applied there have been 41 commits pushed to the master branch:

  • 8853be6: 8316906: Clarify TLABWasteTargetPercent flag
  • 179c60f: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • baf717f: 8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI
  • a81b088: 8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()"
  • d00e1a3: 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files
  • 5e0be48: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates
  • 92398a6: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"
  • a387205: 8294881: test/hotspot/jtreg/vmTestbase/nsk/jdi/VirtualMachine/dispose/dispose003/TestDescription.java fails
  • 0a4c423: 8287596: Reorg jdk.test.lib.util.ForceGC
  • ec6f129: 8273921: Refactor NSK/JDI tests to create thread using factory
  • ... and 31 more: https://git.openjdk.org/jdk17u-dev/compare/f1c55d2e7ce16223801c55eb872ef7fa055faabf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 11, 2023
@openjdk openjdk bot closed this Oct 11, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 11, 2023

@VladimirKempik @Ilyagavrilin Pushed as commit c8c1c6a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants