Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg #1858

Closed
wants to merge 1 commit into from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Oct 9, 2023

Hi all,

This pull request contains a backport of commit 9ffec67a from the openjdk/jdk21u repository.

The commit being backported was authored by Robbin Ehn on 4 Oct 2023 and had no reviewers.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316566 needs maintainer approval

Issue

  • JDK-8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1858/head:pull/1858
$ git checkout pull/1858

Update a local copy of the PR:
$ git checkout pull/1858
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1858/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1858

View PR using the GUI difftool:
$ git pr show -t 1858

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1858.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 9, 2023

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9ffec67a3f2dada329a9887338c570424a79e7f8 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg Oct 9, 2023
@openjdk
Copy link

openjdk bot commented Oct 9, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 9, 2023

⚠️ @robehn This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 9, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 9, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 9, 2023
@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 3f29f1e: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • 6a0dfaf: 8308223: failure handler missed jcmd.vm.info command
  • aaa6962: 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 9, 2023
@RealCLanger
Copy link
Contributor

/reviewers 1

@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@RealCLanger
Warning: By issuing the /reviewers command in this clean backport pull request, the reviewers check has now been enabled.
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Oct 9, 2023
@RealCLanger
Copy link
Contributor

/reviewers 0

@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@RealCLanger
Warning: By issuing the /reviewers command in this clean backport pull request, the reviewers check has now been enabled.
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 1 (with at least 1 Reviewer).

Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GoeLin
Copy link
Member

GoeLin commented Oct 9, 2023

Hi @robehn, you can please integrate this now. Thanks!

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 9, 2023
@robehn
Copy link
Contributor Author

robehn commented Oct 9, 2023

@GoeLin first thank you for cleaning up my mess, so sorry!!
Thanks!

/integrate

@openjdk
Copy link

openjdk bot commented Oct 9, 2023

Going to push as commit 056ba2d.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 3f29f1e: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • 6a0dfaf: 8308223: failure handler missed jcmd.vm.info command
  • aaa6962: 8290909: MemoryPoolMBean/isUsageThresholdExceeded tests failed with "isUsageThresholdExceeded() returned false, and is still false, while threshold = MMMMMMM and used peak = NNNNNNN"

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 9, 2023
@openjdk openjdk bot closed this Oct 9, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 9, 2023
@openjdk
Copy link

openjdk bot commented Oct 9, 2023

@robehn Pushed as commit 056ba2d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants