Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8274983: C1 optimizes the invocation of private interface methods #186

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 2, 2022

Clean backport of JDK-8274983.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8274983: C1 optimizes the invocation of private interface methods

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/186/head:pull/186
$ git checkout pull/186

Update a local copy of the PR:
$ git checkout pull/186
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/186/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 186

View PR using the GUI difftool:
$ git pr show -t 186

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/186.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 2, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 21d9ca6cd942ac98a3be2577ded8eaf92dac7d46 8274983: C1 optimizes the invocation of private interface methods Mar 2, 2022
@openjdk
Copy link

openjdk bot commented Mar 2, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 2, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8274983: C1 optimizes the invocation of private interface methods

Reviewed-by: xliu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 2, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 2, 2022

Webrevs

Copy link
Member

@navyxliu navyxliu left a comment

LGTM.
I am not a reviewer. We still need other reviewers to approve it.

@TheRealMDoerr
Copy link
Contributor Author

TheRealMDoerr commented Mar 3, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 3, 2022

Going to push as commit 977e773.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 23b7f7e: 8281043: Intrinsify recursive ObjectMonitor locking for PPC64

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 3, 2022
@openjdk openjdk bot closed this Mar 3, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 3, 2022
@openjdk
Copy link

openjdk bot commented Mar 3, 2022

@TheRealMDoerr Pushed as commit 977e773.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants