Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed #1866

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 10, 2023

I backport this for parity with 17.0.10-oracle.

Several smaller resolves, especially in the ProblemList.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8270199 needs maintainer approval

Issue

  • JDK-8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1866/head:pull/1866
$ git checkout pull/1866

Update a local copy of the PR:
$ git checkout pull/1866
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1866/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1866

View PR using the GUI difftool:
$ git pr show -t 1866

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1866.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 10, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 16e0ad0ad088af3ba1c9903ed8df60799a1ba651 8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed Oct 10, 2023
@openjdk
Copy link

openjdk bot commented Oct 10, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 10, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 10, 2023

Webrevs

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Oct 11, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Oct 11, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8270199: Most SA tests are skipped on macosx-aarch64 because all executables are signed

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 19 new commits pushed to the master branch:

  • fa42a3e: 8317705: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-ppc64le and aix due to JDK-8248691
  • 8a92a65: 8317706: Exclude java/awt/Graphics2D/DrawString/RotTransText.java on linux
  • c8c1c6a: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
  • 8853be6: 8316906: Clarify TLABWasteTargetPercent flag
  • 179c60f: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • baf717f: 8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI
  • a81b088: 8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()"
  • d00e1a3: 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files
  • 5e0be48: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates
  • 92398a6: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/056ba2d7d90749d70925e2e1c7d6daa66c6992c5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 12, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 12, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 12, 2023

Going to push as commit c17878a.
Since your change was applied there have been 19 commits pushed to the master branch:

  • fa42a3e: 8317705: ProblemList sun/tools/jstat/jstatLineCountsX.sh on linux-ppc64le and aix due to JDK-8248691
  • 8a92a65: 8317706: Exclude java/awt/Graphics2D/DrawString/RotTransText.java on linux
  • c8c1c6a: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
  • 8853be6: 8316906: Clarify TLABWasteTargetPercent flag
  • 179c60f: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • baf717f: 8309974: some JVMCI tests fail when VM options include -XX:+EnableJVMCI
  • a81b088: 8232839: JDI AfterThreadDeathTest.java failed due to "FAILED: Did not get expected IllegalThreadStateException on a StepRequest.enable()"
  • d00e1a3: 8308116: jdk.test.lib.compiler.InMemoryJavaCompiler.compile does not close files
  • 5e0be48: 8284047: Harmonize/Standardize the SSLSocket/SSLEngine/SSLSocketSSLEngine test templates
  • 92398a6: 8300727: java/awt/List/ListGarbageCollectionTest/AwtListGarbageCollectionTest.java failed with "List wasn't garbage collected"
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/056ba2d7d90749d70925e2e1c7d6daa66c6992c5...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 12, 2023
@openjdk openjdk bot closed this Oct 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 12, 2023
@openjdk
Copy link

openjdk bot commented Oct 12, 2023

@GoeLin Pushed as commit c17878a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8270199 branch October 12, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants