8317960: [17u] Excessive CPU usage on AbstractQueuedSynchronized.isEnqueued

[alvdavi]

This patch brings the AbstractQueuedSynchronizer related changes from JDK-8277090 to fix a performance issue that can happen in JDK17 too.

The rest of JDK-8277090 are done mostly in preparation of virtual threads and are covered under CSR JDK-8285450. There is no plan at the moment to backport the rest of the changes to 17.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8317960 needs maintainer approval

Issue

• JDK-8317960: [17u] Excessive CPU usage on AbstractQueuedSynchronized.isEnqueued (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1875/head:pull/1875
$ git checkout pull/1875

Update a local copy of the PR:
$ git checkout pull/1875
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1875/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1875

View PR using the GUI difftool:
$ git pr show -t 1875

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1875.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back alvdavi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (2e589554)
• 00: Full (b5582294)

[openjdk]

⚠️ @alvdavi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[alvdavi]

/approval

[openjdk]

@alvdavi usage: /approval [<id>] (request|cancel) [<text>]

[alvdavi]

/approval request Change is present in JDK21 and considered safe.

[openjdk]

@alvdavi
8317960: The approval request has been created successfully.

[openjdk]

@alvdavi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317960: [17u] Excessive CPU usage on AbstractQueuedSynchronized.isEnqueued

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 115 new commits pushed to the master branch:

• a8ea3c2: 8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state
• 8bf03b9: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
• bf0fb69: 8320885: Bump update version for OpenJDK: jdk-17.0.11
• 9165f77: 8271566: DSA signature length value is not accurate in P11Signature
• cd52f99: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds
• 410b893: 8319187: Add three eMudhra emSign roots
• 04ac9fe: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
• 9128c89: 8277307: Pre shared key sent under both session_ticket and pre_shared_key extensions
• 770b3d6: 8320209: VectorMaskGen clobbers rflags on x86_64
• d335f04: 8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
• ... and 105 more: https://git.openjdk.org/jdk17u-dev/compare/c17878a93b6b2c52380f8240a88f463adadba1c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[alvdavi]

/integrate

[openjdk]

@alvdavi
Your change (at version 2e58955) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit 14e6812.
Since your change was applied there have been 116 commits pushed to the master branch:

• 78cc634: 8295274: HelidonAppTest.java fails "assert(event->should_commit()) failed: invariant" from compiled frame"
• a8ea3c2: 8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state
• 8bf03b9: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
• bf0fb69: 8320885: Bump update version for OpenJDK: jdk-17.0.11
• 9165f77: 8271566: DSA signature length value is not accurate in P11Signature
• cd52f99: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds
• 410b893: 8319187: Add three eMudhra emSign roots
• 04ac9fe: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
• 9128c89: 8277307: Pre shared key sent under both session_ticket and pre_shared_key extensions
• 770b3d6: 8320209: VectorMaskGen clobbers rflags on x86_64
• ... and 106 more: https://git.openjdk.org/jdk17u-dev/compare/c17878a93b6b2c52380f8240a88f463adadba1c2...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @alvdavi Pushed as commit 14e6812.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.