Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!" #1878

Closed
wants to merge 1 commit into from

Conversation

amosshi
Copy link
Contributor

@amosshi amosshi commented Oct 15, 2023

  • Backport of JDK-8297296
  • Test succeeded in local dev box

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8297296 needs maintainer approval

Issue

  • JDK-8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!" (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1878/head:pull/1878
$ git checkout pull/1878

Update a local copy of the PR:
$ git checkout pull/1878
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1878/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1878

View PR using the GUI difftool:
$ git pr show -t 1878

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1878.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 15, 2023

👋 Welcome back amosshi! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0ed6d0b456e58e4122b97c3d12faabada0d8c530 8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!" Oct 15, 2023
@openjdk
Copy link

openjdk bot commented Oct 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 15, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 15, 2023

Webrevs

@amosshi
Copy link
Contributor Author

amosshi commented Oct 16, 2023

/approval request "Backporting for parity with 17.0.8-oracle. No risk, test fix. Clean backport. Test passes and SAP nightlies pass.”

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@amosshi
8297296: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 16, 2023
Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem list mentiones different bug with the same root cause.
LGTM

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

⚠️ @amosshi This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@amosshi This pull request has not yet been marked as ready for integration.

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

⚠️ @amosshi the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout backport-8297296
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@amosshi This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!"

Reviewed-by: goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 28 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@GoeLin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 17, 2023
@amosshi
Copy link
Contributor Author

amosshi commented Oct 18, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 18, 2023
@openjdk
Copy link

openjdk bot commented Oct 18, 2023

@amosshi
Your change (at version b09a1cc) is now ready to be sponsored by a Committer.

@GoeLin
Copy link
Member

GoeLin commented Oct 19, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

Going to push as commit 5e3d47d.
Since your change was applied there have been 29 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 19, 2023
@openjdk openjdk bot closed this Oct 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 19, 2023
@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@GoeLin @amosshi Pushed as commit 5e3d47d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@amosshi amosshi deleted the backport-8297296 branch October 19, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants