Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10> #1888

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 16, 2023

I backport this for parity with 17.0.10-oracle.

The files have been moved in 17 by backport "8303588: [JVMCI] make JVMCI source directories conform with standard layout". After fixing the patch file to point to the new locations, the patch applies clean.

I include follow-up bug fix JDK-8296821. This also applied clean, except for the ProblemList change.
Problemlisting of the test was not backported.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8296821 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8262901 needs maintainer approval

Issues

  • JDK-8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10> (Bug - P4 - Approved)
  • JDK-8296821: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java fails after JDK-8262901 (Bug - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1888/head:pull/1888
$ git checkout pull/1888

Update a local copy of the PR:
$ git checkout pull/1888
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1888/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1888

View PR using the GUI difftool:
$ git pr show -t 1888

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1888.diff

Webrev

Link to Webrev Comment

@GoeLin GoeLin changed the title Goetz backport 8262901 Backport 6b456f7a9b6344506033dfdc5a59c0f3e95c4b2a Oct 16, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6b456f7a9b6344506033dfdc5a59c0f3e95c4b2a 8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10> Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 16, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 16, 2023

/issue JDK-8296821

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

@GoeLin
Adding additional issue to issue list: 8296821: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java fails after JDK-8262901.

@mlbridge
Copy link

mlbridge bot commented Oct 16, 2023

Webrevs

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10>
8296821: compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/NativeCallTest.java fails after JDK-8262901

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 80460e3: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic
  • 1c5d92f: 8315062: [GHA] get-bootjdk action should return the abolute path
  • 1b858f1: 8302525: Write a test to check various components send Events while mouse and key are used simultaneously
  • 111b523: 8300259: Add test coverage for processing of pending block files in signed JARs
  • 7c3e0d4: 8301570: Test runtime/jni/nativeStack/ needs to detach the native thread
  • f7fb52b: 8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg
  • 436f148: 8296275: Write a test to verify setAccelerator method of JMenuItem
  • b07d8c2: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • 052a05d: 8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose
  • 3637245: 8317772: NMT: Make peak values available in release builds
  • ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/c17878a93b6b2c52380f8240a88f463adadba1c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 17, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 18, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 18, 2023

Going to push as commit 9914915.
Since your change was applied there have been 13 commits pushed to the master branch:

  • 2a5daea: 8315214: Do not run sun/tools/jhsdb tests concurrently
  • 80460e3: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic
  • 1c5d92f: 8315062: [GHA] get-bootjdk action should return the abolute path
  • 1b858f1: 8302525: Write a test to check various components send Events while mouse and key are used simultaneously
  • 111b523: 8300259: Add test coverage for processing of pending block files in signed JARs
  • 7c3e0d4: 8301570: Test runtime/jni/nativeStack/ needs to detach the native thread
  • f7fb52b: 8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg
  • 436f148: 8296275: Write a test to verify setAccelerator method of JMenuItem
  • b07d8c2: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • 052a05d: 8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose
  • ... and 3 more: https://git.openjdk.org/jdk17u-dev/compare/c17878a93b6b2c52380f8240a88f463adadba1c2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 18, 2023
@openjdk openjdk bot closed this Oct 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 18, 2023
@openjdk
Copy link

openjdk bot commented Oct 18, 2023

@GoeLin Pushed as commit 9914915.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8262901 branch October 18, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants