Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8306280: Open source several choice AWT tests #1889

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 16, 2023

I backport this for parity with 17.0.10-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8306280 needs maintainer approval

Issue

  • JDK-8306280: Open source several choice AWT tests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1889/head:pull/1889
$ git checkout pull/1889

Update a local copy of the PR:
$ git checkout pull/1889
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1889/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1889

View PR using the GUI difftool:
$ git pr show -t 1889

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1889.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 16, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d03128d0e5158ea967e714341c019b9af00ac4a1 8306280: Open source several choice AWT tests Oct 16, 2023
@openjdk
Copy link

openjdk bot commented Oct 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 16, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 16, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 16, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8306280: Open source several choice AWT tests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 507 new commits pushed to the master branch:

  • 80460e3: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic
  • 1c5d92f: 8315062: [GHA] get-bootjdk action should return the abolute path
  • 1b858f1: 8302525: Write a test to check various components send Events while mouse and key are used simultaneously
  • 111b523: 8300259: Add test coverage for processing of pending block files in signed JARs
  • 7c3e0d4: 8301570: Test runtime/jni/nativeStack/ needs to detach the native thread
  • f7fb52b: 8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg
  • 436f148: 8296275: Write a test to verify setAccelerator method of JMenuItem
  • b07d8c2: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • 052a05d: 8310321: make JDKOPT_CHECK_CODESIGN_PARAMS more verbose
  • 3637245: 8317772: NMT: Make peak values available in release builds
  • ... and 497 more: https://git.openjdk.org/jdk17u-dev/compare/6cc377db3ed16f37df2ec6bd85f9586e4090feb3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 17, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 18, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 18, 2023

Going to push as commit a41b60e.
Since your change was applied there have been 509 commits pushed to the master branch:

  • 9914915: 8262901: [macos_aarch64] NativeCallTest expected:<-3.8194101E18> but was:<3.02668882E10>
  • 2a5daea: 8315214: Do not run sun/tools/jhsdb tests concurrently
  • 80460e3: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic
  • 1c5d92f: 8315062: [GHA] get-bootjdk action should return the abolute path
  • 1b858f1: 8302525: Write a test to check various components send Events while mouse and key are used simultaneously
  • 111b523: 8300259: Add test coverage for processing of pending block files in signed JARs
  • 7c3e0d4: 8301570: Test runtime/jni/nativeStack/ needs to detach the native thread
  • f7fb52b: 8300272: Improve readability of the test JarWithOneNonDisabledDigestAlg
  • 436f148: 8296275: Write a test to verify setAccelerator method of JMenuItem
  • b07d8c2: 8313691: use close after failing os::fdopen in vmError and ciEnv
  • ... and 499 more: https://git.openjdk.org/jdk17u-dev/compare/6cc377db3ed16f37df2ec6bd85f9586e4090feb3...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 18, 2023
@openjdk openjdk bot closed this Oct 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 18, 2023
@openjdk
Copy link

openjdk bot commented Oct 18, 2023

@GoeLin Pushed as commit a41b60e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant