Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315214: Do not run sun/tools/jhsdb tests concurrently #1890

Closed
wants to merge 1 commit into from

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 17, 2023

Backport 8315214


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315214 needs maintainer approval

Issue

  • JDK-8315214: Do not run sun/tools/jhsdb tests concurrently (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1890/head:pull/1890
$ git checkout pull/1890

Update a local copy of the PR:
$ git checkout pull/1890
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1890/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1890

View PR using the GUI difftool:
$ git pr show -t 1890

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1890.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1e7e2bcf3560e1ad39516fb604e4d8bf85bb54e0 8315214: Do not run sun/tools/jhsdb tests concurrently Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 17, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2023

Webrevs

Copy link
Contributor

@TheRealMDoerr TheRealMDoerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Oct 17, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Oct 17, 2023
@openjdk
Copy link

openjdk bot commented Oct 17, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315214: Do not run sun/tools/jhsdb tests concurrently

Reviewed-by: mdoerr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 80460e3: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic
  • 1c5d92f: 8315062: [GHA] get-bootjdk action should return the abolute path
  • 1b858f1: 8302525: Write a test to check various components send Events while mouse and key are used simultaneously
  • 111b523: 8300259: Add test coverage for processing of pending block files in signed JARs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 17, 2023
@MBaesken
Copy link
Member Author

Hi Martin, thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented Oct 18, 2023

Going to push as commit 2a5daea.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 80460e3: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic
  • 1c5d92f: 8315062: [GHA] get-bootjdk action should return the abolute path
  • 1b858f1: 8302525: Write a test to check various components send Events while mouse and key are used simultaneously
  • 111b523: 8300259: Add test coverage for processing of pending block files in signed JARs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 18, 2023
@openjdk openjdk bot closed this Oct 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 18, 2023
@openjdk
Copy link

openjdk bot commented Oct 18, 2023

@MBaesken Pushed as commit 2a5daea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants