Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312592: New parentheses warnings after HarfBuzz 7.2.0 update #1893

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Oct 18, 2023

Unclean backport to unbreak JDK build on older platforms. The conflict is due to absent build warnings rework in later JDKs.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312592 needs maintainer approval

Issue

  • JDK-8312592: New parentheses warnings after HarfBuzz 7.2.0 update (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1893/head:pull/1893
$ git checkout pull/1893

Update a local copy of the PR:
$ git checkout pull/1893
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1893/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1893

View PR using the GUI difftool:
$ git pr show -t 1893

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1893.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 18, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ea067fc3d2b1fecda694442c7921ecb980377c1e 8312592: New parentheses warnings after HarfBuzz 7.2.0 update Oct 18, 2023
@openjdk
Copy link

openjdk bot commented Oct 18, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 18, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 18, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 18, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

/approval request Unclean backport to unbreak JDK build on older platforms. Requires trivial re-application. Reviewed by Paul Hohensee.

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

@shipilev
8312592: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Oct 19, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312592: New parentheses warnings after HarfBuzz 7.2.0 update

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 73c3316: 8268916: Tests for AffirmTrust roots
  • f1ce4ef: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases
  • 6414676: 8291154: Create a non static nested class without enclosing class throws VerifyError
  • 10b7536: 8275333: Print count in "Too many recored phases?" assert
  • e80200f: 8312395: Improve assertions in growableArray
  • 05c6ae4: 8312078: [PPC] JcmdScale.java Failing on AIX
  • 5e3d47d: 8297296: java/awt/Mouse/EnterExitEvents/DragWindowTest.java fails with "No MouseReleased event on label!"
  • 4d246bb: 8297142: jdk/jfr/event/runtime/TestShutdown.java fails on Linux ppc64le and Linux aarch64
  • 0b149e0: Merge
  • 9c16e89: 8317643: [17u] Remove designator DEFAULT_PROMOTED_VERSION_PRE=ea for release 17.0.9
  • ... and 26 more: https://git.openjdk.org/jdk17u-dev/compare/c17878a93b6b2c52380f8240a88f463adadba1c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 25, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

Going to push as commit 73e4745.
Since your change was applied there have been 43 commits pushed to the master branch:

  • c83100c: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java
  • 39c8bb2: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails
  • 8bde7d4: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails
  • 5eeb41a: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
  • 748ccc5: 8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10
  • ffb4ef2: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
  • 9a1f8cb: 8311511: Improve description of NativeLibrary JFR event
  • 73c3316: 8268916: Tests for AffirmTrust roots
  • f1ce4ef: 8317967: Enhance test/jdk/javax/net/ssl/TLSCommon/SSLEngineTestCase.java to handle default cases
  • 6414676: 8291154: Create a non static nested class without enclosing class throws VerifyError
  • ... and 33 more: https://git.openjdk.org/jdk17u-dev/compare/c17878a93b6b2c52380f8240a88f463adadba1c2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2023
@openjdk openjdk bot closed this Oct 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@shipilev Pushed as commit 73e4745.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8312592-harfbuzz-gcc6 branch December 11, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants