Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8291154: Create a non static nested class without enclosing class throws VerifyError #1894

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 19, 2023

I backport this for parity with 17.0.10-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8291154 needs maintainer approval

Issue

  • JDK-8291154: Create a non static nested class without enclosing class throws VerifyError (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1894/head:pull/1894
$ git checkout pull/1894

Update a local copy of the PR:
$ git checkout pull/1894
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1894/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1894

View PR using the GUI difftool:
$ git pr show -t 1894

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1894.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 19, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f96aee74010476a850175f7012c196e40a31c188 8291154: Create a non static nested class without enclosing class throws VerifyError Oct 19, 2023
@openjdk
Copy link

openjdk bot commented Oct 19, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 19, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 19, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 19, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 20, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8291154: Create a non static nested class without enclosing class throws VerifyError

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e80200f: 8312395: Improve assertions in growableArray

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 23, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 23, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 23, 2023

Going to push as commit 6414676.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 10b7536: 8275333: Print count in "Too many recored phases?" assert
  • e80200f: 8312395: Improve assertions in growableArray

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 23, 2023
@openjdk openjdk bot closed this Oct 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 23, 2023
@openjdk
Copy link

openjdk bot commented Oct 23, 2023

@GoeLin Pushed as commit 6414676.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant