Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317920: JDWP-agent sends broken exception event with onthrow option #1902

Conversation

parttimenerd
Copy link
Contributor

@parttimenerd parttimenerd commented Oct 23, 2023

Fixes the bug that is in the JDWP-agent since JDK 1.5.

The original patch did not apply cleanly because Virtual Threads are not present in JDK 17 and the Debuggee class changed slightly.

Tested on Mac M1 with the added test case, the code is platform-independent.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8317920 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8317920: JDWP-agent sends broken exception event with onthrow option (Bug - P4 - Approved) ⚠️ Issue is already resolved. Consider making this a "backport pull request" by setting the PR title to Backport <hash> with the hash of the original commit. See Backports.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1902/head:pull/1902
$ git checkout pull/1902

Update a local copy of the PR:
$ git checkout pull/1902
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1902/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1902

View PR using the GUI difftool:
$ git pr show -t 1902

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1902.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 23, 2023

👋 Welcome back jbechberger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Oct 23, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 23, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

⚠️ @parttimenerd This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@parttimenerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317920: JDWP-agent sends broken exception event with onthrow option

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • 4b6ac09: 8317327: Remove JT_JAVA dead code in jib-profiles.js
  • 8018d07: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed
  • 340a389: 8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory
  • 401969c: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
  • e3d52aa: 8269425: 2 jdk/jfr/api/consumer/streaming tests failed to attach
  • 253acc6: 8271826: mark hotspot runtime/condy tests which ignore external VM flags
  • cd6cb73: 8310265: (process) jspawnhelper should not use argv[0]
  • d4ed7c2: 8318855: Extra file added by mistake during the backport of JDK-8283326
  • a273858: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • 348a703: 8318953: RISC-V: Small refactoring for MacroAssembler::test_bit
  • ... and 30 more: https://git.openjdk.org/jdk17u-dev/compare/e80200f3ddaf57fa8a2ccc23222242d0c997bea7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 2, 2023
@parttimenerd
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@parttimenerd
Your change (at version ef9f41f) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 6, 2023

Going to push as commit f60d396.
Since your change was applied there have been 41 commits pushed to the master branch:

  • fa30733: 8318889: C2: add bailout after assert Bad graph detected in build_loop_late
  • 4b6ac09: 8317327: Remove JT_JAVA dead code in jib-profiles.js
  • 8018d07: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed
  • 340a389: 8309778: java/nio/file/Files/CopyAndMove.java fails when using second test directory
  • 401969c: 8298905: Test "java/awt/print/PrinterJob/ImagePrinting/PrintARGBImage.java" fails because the frames of instruction does not display
  • e3d52aa: 8269425: 2 jdk/jfr/api/consumer/streaming tests failed to attach
  • 253acc6: 8271826: mark hotspot runtime/condy tests which ignore external VM flags
  • cd6cb73: 8310265: (process) jspawnhelper should not use argv[0]
  • d4ed7c2: 8318855: Extra file added by mistake during the backport of JDK-8283326
  • a273858: 8318669: Target OS detection in 'test-prebuilt' makefile target is incorrect when running on MSYS2
  • ... and 31 more: https://git.openjdk.org/jdk17u-dev/compare/e80200f3ddaf57fa8a2ccc23222242d0c997bea7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 6, 2023
@openjdk openjdk bot closed this Nov 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 6, 2023
@openjdk
Copy link

openjdk bot commented Nov 6, 2023

@phohensee @parttimenerd Pushed as commit f60d396.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
2 participants