Skip to content

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 24, 2023

I backport this for parity with 17.0.10-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8239801 needs maintainer approval

Issue

  • JDK-8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1907/head:pull/1907
$ git checkout pull/1907

Update a local copy of the PR:
$ git checkout pull/1907
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1907/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1907

View PR using the GUI difftool:
$ git pr show -t 1907

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1907.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b6dddf4ce6072416e17cadefbd8280f959fd93ca 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Oct 24, 2023
@openjdk
Copy link

openjdk bot commented Oct 24, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 24, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 24, 2023

Webrevs

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Oct 25, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 25, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

Going to push as commit 8bde7d4.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 5eeb41a: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
  • 748ccc5: 8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10
  • ffb4ef2: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
  • 9a1f8cb: 8311511: Improve description of NativeLibrary JFR event

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 25, 2023
@openjdk openjdk bot closed this Oct 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@GoeLin Pushed as commit 8bde7d4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant