8273456: Do not hold ttyLock around stack walking

[GoeLin]

A useful change to improve debug printing.

I skipped the change to mutex.hpp as in 17 tty is already at the top of the lock ordering.

I added follow up JDK-8273629

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8273456 needs maintainer approval
• JDK-8273629 needs maintainer approval

Issues

• JDK-8273456: Do not hold ttyLock around stack walking (Sub-task - P4 - Approved)
• JDK-8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs (Bug - P4 - Approved)

Reviewers

• Lutz Schmidt (@RealLucy - Reviewer)
• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1911/head:pull/1911
$ git checkout pull/1911

Update a local copy of the PR:
$ git checkout pull/1911
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1911/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1911

View PR using the GUI difftool:
$ git pr show -t 1911

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1911.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[GoeLin]

/issue 8273629

[openjdk]

@GoeLin
Adding additional issue to issue list: 8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs.

[mlbridge]

Webrevs

• 00: Full (9ce463f0)

[RealLucy]

Looks good.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273456: Do not hold ttyLock around stack walking
8273629: compiler/uncommontrap/TestDeoptOOM.java fails with release VMs

Reviewed-by: lucy, phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 2a9f6e8: 8315644: increase timeout of sun/security/tools/jarsigner/Warning.java
• d4fe30d: 8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize
• 73e4745: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
• c83100c: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java
• 39c8bb2: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails
• 8bde7d4: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails
• 5eeb41a: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
• 748ccc5: 8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10
• ffb4ef2: 8275329: ZGC: vmTestbase/gc/gctests/SoftReference/soft004/soft004.java fails with assert(_phases->length() <= 1000) failed: Too many recored phases?
• 9a1f8cb: 8311511: Improve description of NativeLibrary JFR event

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

Thanks for the reviews!

/integrate

[openjdk]

Going to push as commit 93127b4.
Since your change was applied there have been 12 commits pushed to the master branch:

• 2c75188: 8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage
• 8258f27: 8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns
• 2a9f6e8: 8315644: increase timeout of sun/security/tools/jarsigner/Warning.java
• d4fe30d: 8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize
• 73e4745: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
• c83100c: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java
• 39c8bb2: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails
• 8bde7d4: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails
• 5eeb41a: 8293563: [macos-aarch64] SA core file tests failing with sun.jvm.hotspot.oops.UnknownOopException
• 748ccc5: 8176567: nsk/jdi/ReferenceType/instances/instances002: TestFailure: Unexpected size of referenceType.instances(nsk.share.jdi.TestInterfaceImplementer1): 11, expected: 10
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/73c3316c2fb658c4d495433c79d616a1fbe61209...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 93127b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.