Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns #1915

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 25, 2023


Progress

  • Change must not contain extraneous whitespace
  • JDK-8313252 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1915/head:pull/1915
$ git checkout pull/1915

Update a local copy of the PR:
$ git checkout pull/1915
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1915/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1915

View PR using the GUI difftool:
$ git pr show -t 1915

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1915.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3671d83c87302ead09d4ebce9cb85bdd803a0c20 8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 25, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 2a9f6e8: 8315644: increase timeout of sun/security/tools/jarsigner/Warning.java
  • d4fe30d: 8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize
  • 73e4745: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
  • c83100c: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java
  • 39c8bb2: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails
  • 8bde7d4: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 25, 2023
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2023

Going to push as commit 8258f27.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 2a9f6e8: 8315644: increase timeout of sun/security/tools/jarsigner/Warning.java
  • d4fe30d: 8316778: test hprof lib: invalid array element type from JavaValueArray.elementSize
  • 73e4745: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
  • c83100c: 8299207: [Testbug] Add back test/jdk/java/awt/Graphics2D/DrawPrimitivesTest.java
  • 39c8bb2: 8202931: [macos] java/awt/Choice/ChoicePopupLocation/ChoicePopupLocation.java fails
  • 8bde7d4: 8239801: [macos] java/awt/Focus/UnaccessibleChoice/AccessibleChoiceTest.java fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 26, 2023
@openjdk openjdk bot closed this Oct 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

@MBaesken Pushed as commit 8258f27.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant