Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage #1917

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Oct 25, 2023

I backport this for parity with 17.0.10-oracle.

Resolved problemList. Two tests were not listed.
The other two are identical. Will mark clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8225313 needs maintainer approval

Issue

  • JDK-8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1917/head:pull/1917
$ git checkout pull/1917

Update a local copy of the PR:
$ git checkout pull/1917
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1917

View PR using the GUI difftool:
$ git pr show -t 1917

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1917.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 25, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 09e5321763f3fafe2b0b562f99ec0cd55a59583c 8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 25, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 25, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Oct 25, 2023

/clean

@openjdk openjdk bot added the clean label Oct 25, 2023
@openjdk
Copy link

openjdk bot commented Oct 25, 2023

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Oct 25, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Oct 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225313: serviceability/jvmti/HeapMonitor/MyPackage/HeapMonitorStatObjectCorrectnessTest.java failed with Unexpected high difference percentage

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8258f27: 8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 26, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 26, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 26, 2023

Going to push as commit 2c75188.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 8258f27: 8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 26, 2023
@openjdk openjdk bot closed this Oct 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 26, 2023
@GoeLin GoeLin deleted the goetz_backport_8225313 branch October 26, 2023 18:10
@openjdk
Copy link

openjdk bot commented Oct 26, 2023

@GoeLin Pushed as commit 2c75188.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant