Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312612: handle WideCharToMultiByte return values #1928

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Oct 27, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8312612 needs maintainer approval

Issue

  • JDK-8312612: handle WideCharToMultiByte return values (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1928/head:pull/1928
$ git checkout pull/1928

Update a local copy of the PR:
$ git checkout pull/1928
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1928/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1928

View PR using the GUI difftool:
$ git pr show -t 1928

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1928.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 27, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d9559f9b24ee76c074cefcaf256d11ef5a7cc5b7 8312612: handle WideCharToMultiByte return values Oct 27, 2023
@openjdk
Copy link

openjdk bot commented Oct 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Oct 27, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Oct 27, 2023
@mlbridge
Copy link

mlbridge bot commented Oct 27, 2023

Webrevs

@openjdk openjdk bot added the approval label Oct 31, 2023
@GoeLin
Copy link
Member

GoeLin commented Nov 1, 2023

/approve yes

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@GoeLin
8312612: The approval request has been approved.

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312612: handle WideCharToMultiByte return values

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 57bf412: 8308593: Add KEEPALIVE Extended Socket Options Support for Windows
  • 4a638cb: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • d61229d: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp
  • 03e3232: 6445283: ProgressMonitorInputStream not large file aware (>2GB)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 1, 2023
@MBaesken
Copy link
Member Author

MBaesken commented Nov 2, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 2, 2023

Going to push as commit 8922e52.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 57bf412: 8308593: Add KEEPALIVE Extended Socket Options Support for Windows
  • 4a638cb: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • d61229d: 8314144: gc/g1/ihop/TestIHOPStatic.java fails due to extra concurrent mark with -Xcomp
  • 03e3232: 6445283: ProgressMonitorInputStream not large file aware (>2GB)

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 2, 2023
@openjdk openjdk bot closed this Nov 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 2, 2023
@openjdk
Copy link

openjdk bot commented Nov 2, 2023

@MBaesken Pushed as commit 8922e52.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants