-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed #1937
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
bc2d5d1
to
e5c9d57
Compare
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 8018d07.
Your commit was automatically rebased without conflicts. |
I backport this for parity with 17.0.11-oracle.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1937/head:pull/1937
$ git checkout pull/1937
Update a local copy of the PR:
$ git checkout pull/1937
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1937/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1937
View PR using the GUI difftool:
$ git pr show -t 1937
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1937.diff
Webrev
Link to Webrev Comment