8312126: NullPointerException in CertStore.getCRLs after 8297955

[gnu-andrew]

Hi all,

This pull request contains a backport of commit 3c743cfe from the openjdk/jdk repository.

The commit being backported was authored by Sean Mullan on 15 Sep 2023 and was reviewed by Weijun Wang.

It is a simple fix and clean backport for a regression introduced by JDK-8297955 which was backported in 17.0.8. The new code in JDK-8297955 failed to catch a null IssuerName, allowing a NullPointerException to be thrown instead of the specified CertStoreException.

Thanks.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8312126 needs maintainer approval

Issue

• JDK-8312126: NullPointerException in CertStore.getCRLs after 8297955 (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1951/head:pull/1951
$ git checkout pull/1951

Update a local copy of the PR:
$ git checkout pull/1951
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1951/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1951

View PR using the GUI difftool:
$ git pr show -t 1951

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1951.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back andrew! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @gnu-andrew This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (d1b6c47d)

[gnu-andrew]

/approval request This is a simple fix and clean backport for a regression introduced by JDK-8297955, which was backported in 17.0.8. The revised code in 8297955 now throws a NullPointerException where it should throw a CertStoreException.

[openjdk]

@gnu-andrew
8312126: The approval request has been created successfully.

[GoeLin]

/approve yes

[openjdk]

@GoeLin
8312126: The approval request has been approved.

[openjdk]

@gnu-andrew This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312126: NullPointerException in CertStore.getCRLs after 8297955

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• 8b9a72e: 8317374: Add Let's Encrypt ISRG Root X2
• a4fe7ac: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
• 1240b34: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free
• 5cb86e3: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[gnu-andrew]

Thanks @GoeLin
/integrate

[openjdk]

Going to push as commit 0cdcc13.
Since your change was applied there have been 6 commits pushed to the master branch:

• b506559: 8309258: RISC-V: Add riscv_hwprobe syscall
• 312f8c0: 8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc
• 8b9a72e: 8317374: Add Let's Encrypt ISRG Root X2
• a4fe7ac: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit
• 1240b34: 8276819: javax/print/PrintServiceLookup/FlushCustomClassLoader.java fails to free
• 5cb86e3: 8273831: PrintServiceLookup spawns 2 threads in the current classloader, getting orphaned

Your commit was automatically rebased without conflicts.

[openjdk]

@gnu-andrew Pushed as commit 0cdcc13.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.