Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc #1954

Conversation

feilongjiang
Copy link
Member

@feilongjiang feilongjiang commented Nov 8, 2023

I would like to backport JDK-8319525 to make possible future backports to those AD files smooth.
Applies not clean since 17u does not support generational-zgc yet.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319525 needs maintainer approval

Issue

  • JDK-8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1954/head:pull/1954
$ git checkout pull/1954

Update a local copy of the PR:
$ git checkout pull/1954
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1954/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1954

View PR using the GUI difftool:
$ git pr show -t 1954

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1954.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 8, 2023

👋 Welcome back fjiang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b2504a0f9cff1f4fdf8f5bb20c4b48a53ba0be77 8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc Nov 8, 2023
@openjdk
Copy link

openjdk bot commented Nov 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 8, 2023
@feilongjiang
Copy link
Member Author

feilongjiang commented Nov 8, 2023

/approval request Simple cleanup change renaming two riscv-specific AD files. Low risk.

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

@feilongjiang
8319525: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 8, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 8, 2023

Webrevs

Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@openjdk
Copy link

openjdk bot commented Nov 8, 2023

⚠️ @feilongjiang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@feilongjiang
Copy link
Member Author

GHA build and hotspot:tier1 passed.

@openjdk
Copy link

openjdk bot commented Nov 9, 2023

@feilongjiang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319525: RISC-V: Rename *_riscv64.ad files to *_riscv.ad under riscv/gc

Reviewed-by: fyang

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8b9a72e: 8317374: Add Let's Encrypt ISRG Root X2
  • a4fe7ac: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealFYang) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 9, 2023
@feilongjiang
Copy link
Member Author

Got fix-request-yes, so
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 10, 2023
@openjdk
Copy link

openjdk bot commented Nov 10, 2023

@feilongjiang
Your change (at version 5541303) is now ready to be sponsored by a Committer.

@RealFYang
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 10, 2023

Going to push as commit 312f8c0.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8b9a72e: 8317374: Add Let's Encrypt ISRG Root X2
  • a4fe7ac: 8316461: Fix: make test outputs TEST SUCCESS after unsuccessful exit

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 10, 2023
@openjdk openjdk bot closed this Nov 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 10, 2023
@openjdk
Copy link

openjdk bot commented Nov 10, 2023

@RealFYang @feilongjiang Pushed as commit 312f8c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@feilongjiang feilongjiang deleted the feilongjiang-backport-b2504a0f branch November 10, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants