Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311081: KeytoolReaderP12Test.java fail on localized Windows platform #1959

Closed
wants to merge 1 commit into from

Conversation

tkiriyama
Copy link
Contributor

@tkiriyama tkiriyama commented Nov 15, 2023

Hi all,

I want to backport JDK-8311081 for jdk17u.
This is clean backport.
I verified that KeytoolReaderP12Test.java passes with this fix.

Would you review and sponsor this fix, please?


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ This PR only contains changes already present in the target

Issue

  • JDK-8311081: KeytoolReaderP12Test.java fail on localized Windows platform (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1959/head:pull/1959
$ git checkout pull/1959

Update a local copy of the PR:
$ git checkout pull/1959
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1959/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1959

View PR using the GUI difftool:
$ git pr show -t 1959

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1959.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 15, 2023

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 15, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 15, 2023

Webrevs

@phohensee
Copy link
Member

phohensee commented Nov 27, 2023

@tkiriyama, this needs to be turned into a backport request, per above. The title should be:

Backport b4b2fecb42d9f14d73e8d79a9e59dee4d697f9cf

This looks like it'll be a clean backport once that's done.

@tkiriyama tkiriyama changed the title 8311081: KeytoolReaderP12Test.java fail on localized Windows platform Backport b4b2fecb42d9f14d73e8d79a9e59dee4d697f9cf Nov 28, 2023
@tkiriyama
Copy link
Contributor Author

Thanks! I fixed the title as your advice.

@openjdk openjdk bot changed the title Backport b4b2fecb42d9f14d73e8d79a9e59dee4d697f9cf 8311081: KeytoolReaderP12Test.java fail on localized Windows platform Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

⚠️ @tkiriyama This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@phohensee
Copy link
Member

Please add a /approvel comment to request maintainer approval. Once you have approval, add /integrate and I can sponsor.

@tkiriyama
Copy link
Contributor Author

/approval

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@tkiriyama usage: /approval [<id>] (request|cancel) [<text>]

@tkiriyama
Copy link
Contributor Author

/approval request

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

@tkiriyama
8311081: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 30, 2023
@GoeLin
Copy link
Member

GoeLin commented Dec 1, 2023

Hi @tkiriyama
Please add reason, risk, testing and whether it is a clean backport to your approval request.
See also https://wiki.openjdk.org/display/JDKUpdates/How+to+contribute+or+backport+a+fix

@tkiriyama
Copy link
Contributor Author

@GoeLin
I'm Sorry. I added the fix request comment to the JBS issue again.

@GoeLin
Copy link
Member

GoeLin commented Dec 4, 2023

Hi @tkiriyama
no problem, I removed it again. You should add a text to the command!
But please first backport it to 21, I will not approve before it is pushed there.

@openjdk openjdk bot removed the approval label Dec 4, 2023
@GoeLin
Copy link
Member

GoeLin commented Dec 14, 2023

@tkiriyama Hint: 21u-dev is open for backports now!

@tkiriyama
Copy link
Contributor Author

@GoeLin
Thanks! I created the pull request for 21u-dev.
openjdk/jdk21u-dev#37

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2024

@tkiriyama This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot added the approval label Jan 26, 2024
@openjdk
Copy link

openjdk bot commented Jan 29, 2024

⚠️ @tkiriyama the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8311081
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Jan 29, 2024

@tkiriyama This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Jan 29, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Feb 26, 2024

@tkiriyama This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 27, 2024
@tkiriyama
Copy link
Contributor Author

I close this pull request because it dupuricate with #2163

@tkiriyama tkiriyama closed this Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants