Skip to content

8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks#1961

Closed
wkia wants to merge 1 commit intoopenjdk:masterfrom
wkia:backport-97ea5bf0ffafaf8009c19483b9a9b1c30401cf9a
Closed

8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks#1961
wkia wants to merge 1 commit intoopenjdk:masterfrom
wkia:backport-97ea5bf0ffafaf8009c19483b9a9b1c30401cf9a

Conversation

@wkia
Copy link

@wkia wkia commented Nov 16, 2023

Clean backport.
No tier1 regressions


Progress

  • Change must not contain extraneous whitespace
  • JDK-8319961 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1961/head:pull/1961
$ git checkout pull/1961

Update a local copy of the PR:
$ git checkout pull/1961
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1961/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1961

View PR using the GUI difftool:
$ git pr show -t 1961

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1961.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 16, 2023

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 97ea5bf0ffafaf8009c19483b9a9b1c30401cf9a 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 16, 2023
@wkia wkia force-pushed the backport-97ea5bf0ffafaf8009c19483b9a9b1c30401cf9a branch from a1e23c3 to c0314cb Compare November 16, 2023 13:36
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@wkia Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean Identical backport; no merge resolution required label Nov 16, 2023
@openjdk
Copy link

openjdk bot commented Nov 16, 2023

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@wkia
Copy link
Author

wkia commented Nov 16, 2023

/approval request Clean backport. No tier1 regressions

@openjdk
Copy link

openjdk bot commented Nov 16, 2023

@wkia
8319961: The approval request has been created successfully.

@openjdk openjdk bot added the approval Requires approval; will be removed when approval is received label Nov 16, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 16, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@wkia This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • bf0fb69: 8320885: Bump update version for OpenJDK: jdk-17.0.11
  • 9165f77: 8271566: DSA signature length value is not accurate in P11Signature
  • cd52f99: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds
  • 410b893: 8319187: Add three eMudhra emSign roots
  • 04ac9fe: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
  • 9128c89: 8277307: Pre shared key sent under both session_ticket and pre_shared_key extensions
  • 770b3d6: 8320209: VectorMaskGen clobbers rflags on x86_64
  • d335f04: 8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
  • 1d7bc8f: 8313781: Add regression tests for large page logging and user-facing error messages
  • 5531ca5: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • ... and 14 more: https://git.openjdk.org/jdk17u-dev/compare/49d5323e09da67cb9eedbdee9f0cf9ebc7fbc9df...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Nov 21, 2023
@wkia
Copy link
Author

wkia commented Nov 21, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@wkia
Your change (at version c0314cb) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

Going to push as commit 450c201.
Since your change was applied there have been 45 commits pushed to the master branch:

  • 5025a97: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
  • be72703: 8301306: java/net/httpclient/* fail with -Xcomp
  • f8f733d: Merge
  • b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all
  • a028120: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
  • 2a019da: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
  • ce670b6: 8318951: Additional negative value check in JPEG decoding
  • 822c496: 8316030: Update Libpng to 1.6.40
  • 9c643df: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 6a9a5ef: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • ... and 35 more: https://git.openjdk.org/jdk17u-dev/compare/49d5323e09da67cb9eedbdee9f0cf9ebc7fbc9df...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2023
@openjdk openjdk bot closed this Dec 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@RealCLanger @wkia Pushed as commit 450c201.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@wkia wkia deleted the backport-97ea5bf0ffafaf8009c19483b9a9b1c30401cf9a branch December 29, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants