Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8320209: VectorMaskGen clobbers rflags on x86_64 #1969

Closed
wants to merge 1 commit into from

Conversation

sviswa7
Copy link

@sviswa7 sviswa7 commented Nov 17, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8320209 needs maintainer approval

Issue

  • JDK-8320209: VectorMaskGen clobbers rflags on x86_64 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1969/head:pull/1969
$ git checkout pull/1969

Update a local copy of the PR:
$ git checkout pull/1969
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1969/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1969

View PR using the GUI difftool:
$ git pr show -t 1969

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1969.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 17, 2023

👋 Welcome back sviswanathan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b05e69f789fa8c9a5320be5a841317abd3b3a235 8320209: VectorMaskGen clobbers rflags on x86_64 Nov 17, 2023
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

This backport pull request has now been updated with issue from the original commit.

@sviswa7 sviswa7 marked this pull request as ready for review November 17, 2023 23:47
@openjdk
Copy link

openjdk bot commented Nov 17, 2023

⚠️ @sviswa7 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 17, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 17, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@sviswa7 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8320209: VectorMaskGen clobbers rflags on x86_64

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

  • 40c29f7: 8279856: Parallel: Use PreservedMarks to record promotion-failed objects
  • 2a37bae: 8262186: Call X509KeyManager.chooseClientAlias once for all key types
  • b7605b7: 8302109: Trivial fixes to btree tests
  • c478c81: 8292067: Convert test/sun/management/jmxremote/bootstrap shell tests to java version
  • e4ddf06: 8320053: GHA: Cross-compile gtest code
  • 3d9cb02: 8317834: java/lang/Thread/IsAlive.java timed out
  • db83123: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b
  • 9bde50e: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit
  • c7fb6ea: 8318759: Add four DigiCert root certificates
  • e0bdb10: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/68f72954dca6166758d7da78628afa0aca2caf88...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 21, 2023
@sviswa7
Copy link
Author

sviswa7 commented Nov 21, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@sviswa7
Your change (at version e40ce7f) is now ready to be sponsored by a Committer.

@sviswa7
Copy link
Author

sviswa7 commented Nov 28, 2023

@shipilev @dwhite-intel could you please sponsor this backport?

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

Going to push as commit 770b3d6.
Since your change was applied there have been 16 commits pushed to the master branch:

  • d335f04: 8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
  • 1d7bc8f: 8313781: Add regression tests for large page logging and user-facing error messages
  • 5531ca5: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • 0f2da83: 8316746: Top of lock-stack does not match the unlocked object
  • 2da7aeb: 8310656: RISC-V: __builtin___clear_cache can fail silently.
  • 40c29f7: 8279856: Parallel: Use PreservedMarks to record promotion-failed objects
  • 2a37bae: 8262186: Call X509KeyManager.chooseClientAlias once for all key types
  • b7605b7: 8302109: Trivial fixes to btree tests
  • c478c81: 8292067: Convert test/sun/management/jmxremote/bootstrap shell tests to java version
  • e4ddf06: 8320053: GHA: Cross-compile gtest code
  • ... and 6 more: https://git.openjdk.org/jdk17u-dev/compare/68f72954dca6166758d7da78628afa0aca2caf88...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2023
@openjdk openjdk bot closed this Nov 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@shipilev @sviswa7 Pushed as commit 770b3d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants