8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM

[phohensee]

I'd like to backport the definition and implementation of com.sun.management.ThreadMXBean.getTotalThreadAllocatedBytes to 17u. The backport CSR is JDK-8320375. A follow-up bugfix backport of JDK-8313081 will be done following this backport. The combined backports have been in production at Amazon for two months with no issues. The backport uses the reserved6 slot in jmm.h in order to preserve binary compatibility with 17u. Per current policy, there is no update to JMM_VERSION in jmm.h and the new method is marked

@since 17.0.11

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8320375 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8304074 needs maintainer approval

Issues

• JDK-8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM (Enhancement - P4 - Approved)
• JDK-8320375: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM (CSR)

Reviewers

• Volker Simonis (@simonis - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1971/head:pull/1971
$ git checkout pull/1971

Update a local copy of the PR:
$ git checkout pull/1971
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1971/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1971

View PR using the GUI difftool:
$ git pr show -t 1971

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1971.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back phh! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 02: Full - Incremental (c093429b)
• 01: Full - Incremental (22905dd5)
• 00: Full (5741ea34)

[simonis]

Looks good to me. Thanks for doing the downport.

[phohensee]

Thanks for the quick review of both this PR and the CSR. Now waiting on CSR approval.

[simonis]

Thanks for updating the since tag. Still good.

[openjdk]

⚠️ @phohensee This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[phohensee]

/approval request Almost clean backport of purely additive JMX feature (doesn't change existing code). In production at Amazon for over two months.

[openjdk]

@phohensee
8304074: The approval request has been created successfully.

[openjdk]

@phohensee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8304074: [JMX] Add an approximation of total bytes allocated on the Java heap by the JVM

Reviewed-by: simonis

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

• 16f319a: 8307990: jspawnhelper must close its writing side of a pipe before reading from it
• 0bc91f6: 8313643: Update HarfBuzz to 8.2.2
• 450c201: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
• 5025a97: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
• be72703: 8301306: java/net/httpclient/* fail with -Xcomp
• f8f733d: Merge
• b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all
• a028120: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
• 2a019da: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
• ce670b6: 8318951: Additional negative value check in JPEG decoding
• ... and 26 more: https://git.openjdk.org/jdk17u-dev/compare/40c29f7d80b5b67718ce071722bd7cfaecdf9495...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[phohensee]

/integrate

[openjdk]

Going to push as commit 0bbbd14.
Since your change was applied there have been 42 commits pushed to the master branch:

• 9bf8c2e: 8311645: Memory leak in jspawnhelper spawnChild after JDK-8307990
• af0f057: 8310106: sun.security.ssl.SSLHandshake.getHandshakeProducer() incorrectly checks handshakeConsumers
• 7b51211: 7148092: [macosx] When Alt+down arrow key is pressed, the combobox popup does not appear.
• 644a430: 8054572: [macosx] JComboBox paints the border incorrectly
• 5217b07: 8290399: [macos] Aqua LAF does not fire an action event if combo box menu is displayed
• 4d716cc: 7132796: [macosx] closed/javax/swing/JComboBox/4517214/bug4517214.java fails on MacOS
• 16f319a: 8307990: jspawnhelper must close its writing side of a pipe before reading from it
• 0bc91f6: 8313643: Update HarfBuzz to 8.2.2
• 450c201: 8319961: JvmtiEnvBase doesn't zero _ext_event_callbacks
• 5025a97: 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"
• ... and 32 more: https://git.openjdk.org/jdk17u-dev/compare/40c29f7d80b5b67718ce071722bd7cfaecdf9495...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee Pushed as commit 0bbbd14.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.