Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom" #1972

Closed
wants to merge 3 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 20, 2023

I backport this for parity with 17.0.11-oracle.

I added a test file that was originally added by JDK-8293182: Improve testing of CDS archive heap.

I also had to adapt the pattern checked in the new test as the tracing in 17 does not list the kind of cds klass. (boot, app, array).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8312434 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom" (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1972/head:pull/1972
$ git checkout pull/1972

Update a local copy of the PR:
$ git checkout pull/1972
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1972

View PR using the GUI difftool:
$ git pr show -t 1972

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1972.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the title Goetz backport 8312434 Backport 9f4a9fe488be7ce43f6719c54df25a1fabd8696a Nov 20, 2023
@openjdk openjdk bot changed the title Backport 9f4a9fe488be7ce43f6719c54df25a1fabd8696a 8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom" Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 20, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2023

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Nov 21, 2023

Pre-submit failures:
x64 + x64 minimal: Installing toolchain failed.
Will restart the tests.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test, ClassInPackage.java, defines an empty class. Did you mean instead/in addition include ArchiveHeapTestClass.java?

@openjdk openjdk bot added approval and removed approval labels Nov 29, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 4, 2023

Hi @phohensee,
ClassInPackage.java is not a test, just a class that is put into a jar needed for testing.

I can not add ArchiveHeapTestClass.java because it tests the functionality of 8293182.

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Thanks for the explanation.

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

  • f8f733d: Merge
  • b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all
  • a028120: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
  • 2a019da: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
  • ce670b6: 8318951: Additional negative value check in JPEG decoding
  • 822c496: 8316030: Update Libpng to 1.6.40
  • 9c643df: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 6a9a5ef: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • be33d68: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler
  • 8248b0c: 8302149: Speed up compiler/jsr292/methodHandleExceptions/TestAMEnotNPE.java
  • ... and 27 more: https://git.openjdk.org/jdk17u-dev/compare/db83123c5cc054cee5663201ead92410e6487d81...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 6, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

Going to push as commit 5025a97.
Since your change was applied there have been 38 commits pushed to the master branch:

  • be72703: 8301306: java/net/httpclient/* fail with -Xcomp
  • f8f733d: Merge
  • b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all
  • a028120: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
  • 2a019da: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
  • ce670b6: 8318951: Additional negative value check in JPEG decoding
  • 822c496: 8316030: Update Libpng to 1.6.40
  • 9c643df: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 6a9a5ef: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • be33d68: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler
  • ... and 28 more: https://git.openjdk.org/jdk17u-dev/compare/db83123c5cc054cee5663201ead92410e6487d81...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2023
@openjdk openjdk bot closed this Dec 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@GoeLin Pushed as commit 5025a97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8312434 branch December 6, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants