8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"

[GoeLin]

I backport this for parity with 17.0.11-oracle.

I added a test file that was originally added by JDK-8293182: Improve testing of CDS archive heap.

I also had to adapt the pattern checked in the new test as the tracing in 17 does not list the kind of cds klass. (boot, app, array).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8312434 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom" (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1972/head:pull/1972
$ git checkout pull/1972

Update a local copy of the PR:
$ git checkout pull/1972
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1972

View PR using the GUI difftool:
$ git pr show -t 1972

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1972.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (5c9a6ca9)
• 00: Full (04d5aba4)

[GoeLin]

Pre-submit failures:
x64 + x64 minimal: Installing toolchain failed.
Will restart the tests.

[phohensee]

The new test, ClassInPackage.java, defines an empty class. Did you mean instead/in addition include ArchiveHeapTestClass.java?

[GoeLin]

Hi @phohensee,
ClassInPackage.java is not a test, just a class that is put into a jar needed for testing.

I can not add ArchiveHeapTestClass.java because it tests the functionality of 8293182.

[phohensee]

Ok. Thanks for the explanation.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312434: SPECjvm2008/xml.transform with CDS fails with "can't seal package nu.xom"

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 37 new commits pushed to the master branch:

• f8f733d: Merge
• b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all
• a028120: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
• 2a019da: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
• ce670b6: 8318951: Additional negative value check in JPEG decoding
• 822c496: 8316030: Update Libpng to 1.6.40
• 9c643df: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
• 6a9a5ef: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
• be33d68: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler
• 8248b0c: 8302149: Speed up compiler/jsr292/methodHandleExceptions/TestAMEnotNPE.java
• ... and 27 more: https://git.openjdk.org/jdk17u-dev/compare/db83123c5cc054cee5663201ead92410e6487d81...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 5025a97.
Since your change was applied there have been 38 commits pushed to the master branch:

• be72703: 8301306: java/net/httpclient/* fail with -Xcomp
• f8f733d: Merge
• b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all
• a028120: 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout
• 2a019da: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
• ce670b6: 8318951: Additional negative value check in JPEG decoding
• 822c496: 8316030: Update Libpng to 1.6.40
• 9c643df: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
• 6a9a5ef: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
• be33d68: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler
• ... and 28 more: https://git.openjdk.org/jdk17u-dev/compare/db83123c5cc054cee5663201ead92410e6487d81...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 5025a97.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.