Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8292067: Convert test/sun/management/jmxremote/bootstrap shell tests to java version #1973

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 20, 2023

I backport this for parity with 17.0.11-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8292067 needs maintainer approval

Issue

  • JDK-8292067: Convert test/sun/management/jmxremote/bootstrap shell tests to java version (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1973/head:pull/1973
$ git checkout pull/1973

Update a local copy of the PR:
$ git checkout pull/1973
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1973/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1973

View PR using the GUI difftool:
$ git pr show -t 1973

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1973.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3993a1f9eaa8353ab8b24fe56c870580ef34fb52 8292067: Convert test/sun/management/jmxremote/bootstrap shell tests to java version Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8292067: Convert test/sun/management/jmxremote/bootstrap shell tests to java version

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • db83123: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b
  • 9bde50e: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit
  • c7fb6ea: 8318759: Add four DigiCert root certificates
  • e0bdb10: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
  • 8860bde: 8294402: Add diagnostic logging to VMProps.checkDockerSupport
  • 68f7295: 8315195: RISC-V: Update hwprobe query for new extensions
  • 49d5323: 8319184: RISC-V: improve MD5 intrinsic

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 21, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Nov 21, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

Going to push as commit c478c81.
Since your change was applied there have been 9 commits pushed to the master branch:

  • e4ddf06: 8320053: GHA: Cross-compile gtest code
  • 3d9cb02: 8317834: java/lang/Thread/IsAlive.java timed out
  • db83123: 8316645: RISC-V: Remove dependency on libatomic by adding cmpxchg 1b
  • 9bde50e: 8319958: test/jdk/java/io/File/libGetXSpace.c does not compile on Windows 32-bit
  • c7fb6ea: 8318759: Add four DigiCert root certificates
  • e0bdb10: 8307311: Timeouts on one macOS 12.6.1 host of two Swing JTableHeader tests
  • 8860bde: 8294402: Add diagnostic logging to VMProps.checkDockerSupport
  • 68f7295: 8315195: RISC-V: Update hwprobe query for new extensions
  • 49d5323: 8319184: RISC-V: improve MD5 intrinsic

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 21, 2023
@openjdk openjdk bot closed this Nov 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@GoeLin Pushed as commit c478c81.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8292067 branch November 21, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant