Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win) #1976

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Nov 20, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8317603 needs maintainer approval

Issue

  • JDK-8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win) (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1976/head:pull/1976
$ git checkout pull/1976

Update a local copy of the PR:
$ git checkout pull/1976
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1976/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1976

View PR using the GUI difftool:
$ git pr show -t 1976

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1976.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 20, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a9b41da9df398ae7e2cf598b2779808d16504e14 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win) Nov 20, 2023
@openjdk
Copy link

openjdk bot commented Nov 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 20, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 20, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • bf0fb69: 8320885: Bump update version for OpenJDK: jdk-17.0.11
  • 9165f77: 8271566: DSA signature length value is not accurate in P11Signature
  • cd52f99: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds
  • 410b893: 8319187: Add three eMudhra emSign roots
  • 04ac9fe: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
  • 9128c89: 8277307: Pre shared key sent under both session_ticket and pre_shared_key extensions
  • 770b3d6: 8320209: VectorMaskGen clobbers rflags on x86_64
  • d335f04: 8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
  • 1d7bc8f: 8313781: Add regression tests for large page logging and user-facing error messages
  • 5531ca5: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • ... and 10 more: https://git.openjdk.org/jdk17u-dev/compare/c7fb6ea7eb41bac13bc58151c63926934c0c25cd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 21, 2023
@MBaesken
Copy link
Member Author

MBaesken commented Dec 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2023

Going to push as commit 56fc06c.
Since your change was applied there have been 25 commits pushed to the master branch:

  • 28e1a33: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"
  • 14e6812: 8317960: [17u] Excessive CPU usage on AbstractQueuedSynchronized.isEnqueued
  • 78cc634: 8295274: HelidonAppTest.java fails "assert(event->should_commit()) failed: invariant" from compiled frame"
  • a8ea3c2: 8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state
  • 8bf03b9: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
  • bf0fb69: 8320885: Bump update version for OpenJDK: jdk-17.0.11
  • 9165f77: 8271566: DSA signature length value is not accurate in P11Signature
  • cd52f99: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds
  • 410b893: 8319187: Add three eMudhra emSign roots
  • 04ac9fe: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
  • ... and 15 more: https://git.openjdk.org/jdk17u-dev/compare/c7fb6ea7eb41bac13bc58151c63926934c0c25cd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2023
@openjdk openjdk bot closed this Dec 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2023
@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@MBaesken Pushed as commit 56fc06c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant