-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8313782: Add user-facing warning if THPs are enabled but cannot be used #1978
8313782: Add user-facing warning if THPs are enabled but cannot be used #1978
Conversation
👋 Welcome back clanger! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Main reason for requesting this backport is that it comes together with JDK-8313781 which fixes a test failure in hotspot jtreg test runtime/os/TestHugePageDetection.java that we see in certain linux configurations. The introduced warning by itself is helpful, too. Risk medium/low. Tested in GHA and SAP nightlies. |
@RealCLanger |
@RealCLanger This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit 5531ca5.
Your commit was automatically rebased without conflicts. |
@RealCLanger Pushed as commit 5531ca5. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Hi all,
This pull request contains a backport of JDK-8313782, commit 44b5b81f from the openjdk/jdk21u repository.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1978/head:pull/1978
$ git checkout pull/1978
Update a local copy of the PR:
$ git checkout pull/1978
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1978/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1978
View PR using the GUI difftool:
$ git pr show -t 1978
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1978.diff
Webrev
Link to Webrev Comment