Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313781: Add regression tests for large page logging and user-facing error messages #1979

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Nov 21, 2023

Hi all,

This pull request contains a backport of JDK-8313781, commit 99d260c0 from the openjdk/jdk21u repository.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8313781 needs maintainer approval

Issue

  • JDK-8313781: Add regression tests for large page logging and user-facing error messages (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1979/head:pull/1979
$ git checkout pull/1979

Update a local copy of the PR:
$ git checkout pull/1979
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1979/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1979

View PR using the GUI difftool:
$ git pr show -t 1979

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1979.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 21, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 99d260c0ccadea60a48dc8c933972615bcd86b65 8313781: Add regression tests for large page logging and user-facing error messages Nov 21, 2023
@openjdk
Copy link

openjdk bot commented Nov 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 21, 2023

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 21, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 21, 2023

Webrevs

@RealCLanger
Copy link
Contributor Author

/approval request Fixes a test failure in hotspot jtreg test runtime/os/TestHugePageDetection.java that we see in certain linux configurations. Test only. Tested in GHA and SAP nightlies.

@openjdk
Copy link

openjdk bot commented Nov 22, 2023

@RealCLanger
8313781: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 22, 2023
@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313781: Add regression tests for large page logging and user-facing error messages

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 0f2da83: 8316746: Top of lock-stack does not match the unlocked object
  • 2da7aeb: 8310656: RISC-V: __builtin___clear_cache can fail silently.
  • 40c29f7: 8279856: Parallel: Use PreservedMarks to record promotion-failed objects
  • 2a37bae: 8262186: Call X509KeyManager.chooseClientAlias once for all key types
  • b7605b7: 8302109: Trivial fixes to btree tests
  • c478c81: 8292067: Convert test/sun/management/jmxremote/bootstrap shell tests to java version
  • e4ddf06: 8320053: GHA: Cross-compile gtest code
  • 3d9cb02: 8317834: java/lang/Thread/IsAlive.java timed out

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 23, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

Going to push as commit 1d7bc8f.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 5531ca5: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • 0f2da83: 8316746: Top of lock-stack does not match the unlocked object
  • 2da7aeb: 8310656: RISC-V: __builtin___clear_cache can fail silently.
  • 40c29f7: 8279856: Parallel: Use PreservedMarks to record promotion-failed objects
  • 2a37bae: 8262186: Call X509KeyManager.chooseClientAlias once for all key types
  • b7605b7: 8302109: Trivial fixes to btree tests
  • c478c81: 8292067: Convert test/sun/management/jmxremote/bootstrap shell tests to java version
  • e4ddf06: 8320053: GHA: Cross-compile gtest code
  • 3d9cb02: 8317834: java/lang/Thread/IsAlive.java timed out

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 23, 2023
@openjdk openjdk bot closed this Nov 23, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 23, 2023
@openjdk
Copy link

openjdk bot commented Nov 23, 2023

@RealCLanger Pushed as commit 1d7bc8f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant