8271566: DSA signature length value is not accurate in P11Signature

[martinuy]

Hi,

I would like to request a review for the backport of 8271566 to jdk17u-dev.

The original patch does not apply cleanly due to context differences in some parts of P11Key.java. In particular, jdk17u lacks of 8274393 that introduces @SuppressWarnings("serial") lines. jdk17u does not have the 8160675 enhancement so it does not need 8274393 to be backported as a dependency.

No regressions observed in the "jdk/sun/security/pkcs11" tests category.

Thanks,
Martin.-

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8271566 needs maintainer approval

Issue

• JDK-8271566: DSA signature length value is not accurate in P11Signature (Bug - P4 - Approved)

Reviewers

• Andrew Dinn (@adinn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1982/head:pull/1982
$ git checkout pull/1982

Update a local copy of the PR:
$ git checkout pull/1982
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1982/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1982

View PR using the GUI difftool:
$ git pr show -t 1982

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1982.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbalao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (af563347)
• 00: Full (405dab10)

[adinn]

This is really just a clean backport modulo a few small changes to accommodate the missing serialization warnings. So all good as far as correctness is concerned.

[openjdk]

⚠️ @martinuy This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@martinuy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8271566: DSA signature length value is not accurate in P11Signature

Reviewed-by: adinn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• d335f04: 8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
• 1d7bc8f: 8313781: Add regression tests for large page logging and user-facing error messages
• 5531ca5: 8313782: Add user-facing warning if THPs are enabled but cannot be used
• 0f2da83: 8316746: Top of lock-stack does not match the unlocked object
• 2da7aeb: 8310656: RISC-V: __builtin___clear_cache can fail silently.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[martinuy]

/integrate

[openjdk]

Going to push as commit 9165f77.
Since your change was applied there have been 10 commits pushed to the master branch:

• cd52f99: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds
• 410b893: 8319187: Add three eMudhra emSign roots
• 04ac9fe: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
• 9128c89: 8277307: Pre shared key sent under both session_ticket and pre_shared_key extensions
• 770b3d6: 8320209: VectorMaskGen clobbers rflags on x86_64
• d335f04: 8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
• 1d7bc8f: 8313781: Add regression tests for large page logging and user-facing error messages
• 5531ca5: 8313782: Add user-facing warning if THPs are enabled but cannot be used
• 0f2da83: 8316746: Top of lock-stack does not match the unlocked object
• 2da7aeb: 8310656: RISC-V: __builtin___clear_cache can fail silently.

Your commit was automatically rebased without conflicts.

[openjdk]

@martinuy Pushed as commit 9165f77.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.