Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8319187: Add three eMudhra emSign roots #1983

Closed
wants to merge 3 commits into from

Conversation

luchenlin
Copy link

@luchenlin luchenlin commented Nov 22, 2023

I backport this for parity with 17.0.10-oracle.

Adapt the location of the certs and the hash in the test.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319187 needs maintainer approval

Issue

  • JDK-8319187: Add three eMudhra emSign roots (Enhancement - P2 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1983/head:pull/1983
$ git checkout pull/1983

Update a local copy of the PR:
$ git checkout pull/1983
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1983/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1983

View PR using the GUI difftool:
$ git pr show -t 1983

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1983.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 22, 2023

👋 Welcome back andrewlu! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0bda467f6e29c866c661e88a76a9fe3efc0a0d19 8319187: Add three eMudhra emSign roots Nov 22, 2023
@openjdk
Copy link

openjdk bot commented Nov 22, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 22, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 22, 2023

Webrevs

@openjdk openjdk bot added the approval label Nov 23, 2023
@MBaesken
Copy link
Member

what happened to the [EmSignRootG2CA.java] test ?
(openjdk/jdk@0bda467#diff-dd4b9e7c43db510dd7c791660c72f1cdf245a4c9037f9f29f1a2d6edece0eeee)

@luchenlin
Copy link
Author

what happened to the [EmSignRootG2CA.java] test ? (openjdk/jdk@0bda467#diff-dd4b9e7c43db510dd7c791660c72f1cdf245a4c9037f9f29f1a2d6edece0eeee)

hi @MBaesken , local tests all pass, including this one.

@MBaesken
Copy link
Member

EmSignRootG2CA is missing from this PR, why ?
Compare the files of your PR with e.g. the 21 version where test EmSignRootG2CA is included
https://github.com/openjdk/jdk21u/pull/376/files

@luchenlin
Copy link
Author

EmSignRootG2CA is missing from this PR, why ? Compare the files of your PR with e.g. the 21 version where test EmSignRootG2CA is included https://github.com/openjdk/jdk21u/pull/376/files

hi @MBaesken , sorry that i miss to commit this file, and my local test record shows it passes test, thanks for review.

@openjdk
Copy link

openjdk bot commented Nov 24, 2023

⚠️ @luchenlin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@luchenlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319187: Add three eMudhra emSign roots

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • d335f04: 8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
  • 1d7bc8f: 8313781: Add regression tests for large page logging and user-facing error messages
  • 5531ca5: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • 0f2da83: 8316746: Top of lock-stack does not match the unlocked object
  • 2da7aeb: 8310656: RISC-V: __builtin___clear_cache can fail silently.

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@MBaesken) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Nov 27, 2023
@luchenlin
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

@luchenlin
Your change (at version f5a45ca) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 28, 2023

Going to push as commit 410b893.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 04ac9fe: 8315692: Parallelize gc/stress/TestStressRSetCoarsening.java test
  • 9128c89: 8277307: Pre shared key sent under both session_ticket and pre_shared_key extensions
  • 770b3d6: 8320209: VectorMaskGen clobbers rflags on x86_64
  • d335f04: 8293343: sun/management/jmxremote/bootstrap/RmiSslNoKeyStoreTest.java failed with "Agent communication error: java.io.EOFException"
  • 1d7bc8f: 8313781: Add regression tests for large page logging and user-facing error messages
  • 5531ca5: 8313782: Add user-facing warning if THPs are enabled but cannot be used
  • 0f2da83: 8316746: Top of lock-stack does not match the unlocked object
  • 2da7aeb: 8310656: RISC-V: __builtin___clear_cache can fail silently.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 28, 2023
@openjdk openjdk bot closed this Nov 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 28, 2023
@openjdk
Copy link

openjdk bot commented Nov 28, 2023

@shipilev @luchenlin Pushed as commit 410b893.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
3 participants