Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address #1984

Closed

Conversation

varada1110
Copy link

@varada1110 varada1110 commented Nov 23, 2023

Hi all,

This pull request contains a backport of commit 3ccb3c0e from the openjdk/jdk repository.

The commit being backported was authored by Jaikiran Pai on 7 Jun 2023 and was reviewed by Daniel Jeliński and Daniel Fuchs.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8305906 needs maintainer approval

Issue

  • JDK-8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1984/head:pull/1984
$ git checkout pull/1984

Update a local copy of the PR:
$ git checkout pull/1984
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1984/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1984

View PR using the GUI difftool:
$ git pr show -t 1984

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1984.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 23, 2023

👋 Welcome back varadam! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3ccb3c0e09f9a414229d3f76031f3fc8f271c936 8305906: HttpClient may use incorrect key when finding pooled HTTP/2 connection for IPv6 address Nov 23, 2023
@openjdk
Copy link

openjdk bot commented Nov 23, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 23, 2023

⚠️ @varada1110 This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 23, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 23, 2023

Webrevs

@varada1110 varada1110 marked this pull request as draft November 23, 2023 06:33
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 23, 2023
@varada1110 varada1110 marked this pull request as ready for review November 23, 2023 07:21
@varada1110 varada1110 marked this pull request as draft November 23, 2023 07:22
@openjdk openjdk bot added rfr Pull request is ready for review and removed rfr Pull request is ready for review labels Nov 23, 2023
@openjdk openjdk bot added approval and removed approval labels Jan 12, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 18, 2024

@varada1110 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@varada1110 varada1110 closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant