Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311583: tableswitch broken by JDK-8310577 #1988

Closed
wants to merge 1 commit into from

Conversation

martinuy
Copy link
Contributor

@martinuy martinuy commented Nov 27, 2023

Hi,

The 17u backport of 8311583 does not apply cleanly because of the absence of 8310577. In particular, the data type used in Bytecodes::special_length_at is jlong/jint instead of int. In my view, 8310577 should not be considered a dependency because: 1) the data type will be replaced by int64_t anyways and we can cast to int where appropriate (in the same line), 2) 8310577 is an enhancement, 3) touches multiple unrelated files (far beyond the scope of 8311583) and 4) has broken things —and has follow up fixes that would be needed, propagating risks—. In fact, 8311583 is a follow up fix of 8310577. I want 8311583 in 17u as a dependency of another fix.

No regressions observed in the hotspot/jtreg/runtime/verifier tests category.

Thanks,
Martin.-


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8311583 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8311583: tableswitch broken by JDK-8310577 (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/1988/head:pull/1988
$ git checkout pull/1988

Update a local copy of the PR:
$ git checkout pull/1988
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/1988/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1988

View PR using the GUI difftool:
$ git pr show -t 1988

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/1988.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 27, 2023

👋 Welcome back mbalao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 135f64e603266e0bb8852edf77d21a9cd79388ce 8311583: tableswitch broken by JDK-8310577 Nov 27, 2023
@openjdk
Copy link

openjdk bot commented Nov 27, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Nov 27, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 27, 2023

Webrevs

@martinuy martinuy closed this Nov 27, 2023
@martinuy
Copy link
Contributor Author

I will retire this backport as further investigation has shown that it's not strictly a dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
1 participant