Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273056: java.util.random does not correctly sample exponential or Gaussian distributions #199

Closed
wants to merge 1 commit into from

Conversation

lutkerd
Copy link
Contributor

@lutkerd lutkerd commented Mar 4, 2022

…ussian distributions

Clean backport of JDK-8273056


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273056: java.util.random does not correctly sample exponential or Gaussian distributions ⚠️ Issue is not open.

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/199/head:pull/199
$ git checkout pull/199

Update a local copy of the PR:
$ git checkout pull/199
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 199

View PR using the GUI difftool:
$ git pr show -t 199

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/199.diff

…ussian distributions

Co-authored-by: Guy Steele <gls@openjdk.org>
Reviewed-by: bpb, darcy
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 4, 2022

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8273056: java.util.random does not correctly sample exponential or Ga… 8273056: java.util.random does not correctly sample exponential or Gaussian distributions Mar 4, 2022
@openjdk
Copy link

openjdk bot commented Mar 4, 2022

⚠️ @lutkerd a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master a51a5f03a33ae1d17b951dfdc27a257a9403d488
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 4, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 4, 2022

Webrevs

@phohensee
Copy link
Member

/clean

@openjdk
Copy link

openjdk bot commented Mar 4, 2022

@phohensee Can only mark backport pull requests, with an original hash, as clean

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@openjdk
Copy link

openjdk bot commented Mar 4, 2022

⚠️ @lutkerd the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout master
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Mar 4, 2022

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273056: java.util.random does not correctly sample exponential or Gaussian distributions

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Mar 4, 2022
@TheRealMDoerr
Copy link
Contributor

Seems like Skara doesn't recognize this PR as backport. Also, it warns because no new branch was used.
I suggest to create a new branch and a new PR with title "Backport 3d98ec1b7bc77237177ecfc069c0e9a7e75829bc" and let the Skara bot do the job (title and labels ...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review
4 participants