-
Notifications
You must be signed in to change notification settings - Fork 231
8273056: java.util.random does not correctly sample exponential or Gaussian distributions #199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ussian distributions Co-authored-by: Guy Steele <gls@openjdk.org> Reviewed-by: bpb, darcy
|
👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into |
|
To avoid this situation, create a new branch for your changes and reset the Then proceed to create a new pull request with |
|
/clean |
|
@phohensee Can only mark backport pull requests, with an original hash, as clean |
phohensee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm.
|
|
@lutkerd This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
Seems like Skara doesn't recognize this PR as backport. Also, it warns because no new branch was used. |
…ussian distributions
Clean backport of JDK-8273056
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/199/head:pull/199$ git checkout pull/199Update a local copy of the PR:
$ git checkout pull/199$ git pull https://git.openjdk.java.net/jdk17u-dev pull/199/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 199View PR using the GUI difftool:
$ git pr show -t 199Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/199.diff