Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert #200

Closed
wants to merge 1 commit into from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Mar 7, 2022

Clean Backport of JDK-8275638. Should get backported together with JDK-8278966.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/200/head:pull/200
$ git checkout pull/200

Update a local copy of the PR:
$ git checkout pull/200
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 200

View PR using the GUI difftool:
$ git pr show -t 200

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/200.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2022

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b9a477bf19d9f276f6b1da8984eb56d7bd5fc137 8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert Mar 7, 2022
@openjdk
Copy link

openjdk bot commented Mar 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 7, 2022

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8275638: GraphKit::combine_exception_states fails with "matching stack sizes" assert

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2022

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Mar 8, 2022

Going to push as commit a8775f1.
Since your change was applied there have been 2 commits pushed to the master branch:

  • ff1ef50: 8273056: java.util.random does not correctly sample exponential or Gaussian distributions
  • e2103de: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 8, 2022
@openjdk openjdk bot closed this Mar 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 8, 2022
@TheRealMDoerr TheRealMDoerr deleted the 8275638_C2_stack branch March 8, 2022 17:32
@openjdk
Copy link

openjdk bot commented Mar 8, 2022

@TheRealMDoerr Pushed as commit a8775f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant