Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library #2007

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 30, 2023

I backport this for parity with 17.0.11-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301846 needs maintainer approval

Issue

  • JDK-8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2007/head:pull/2007
$ git checkout pull/2007

Update a local copy of the PR:
$ git checkout pull/2007
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2007

View PR using the GUI difftool:
$ git pr show -t 2007

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2007.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 613a3cc6896ef3c3f836d44de9b2fb05beba6e72 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2023

Webrevs

@openjdk openjdk bot added the approval label Dec 1, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • e4cb6aa: 8287832: jdk/jfr/event/runtime/TestActiveSettingEvent.java failed with "Expected two batches of Active Setting events"
  • 56fc06c: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • 28e1a33: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"
  • 14e6812: 8317960: [17u] Excessive CPU usage on AbstractQueuedSynchronized.isEnqueued
  • 78cc634: 8295274: HelidonAppTest.java fails "assert(event->should_commit()) failed: invariant" from compiled frame"
  • a8ea3c2: 8288663: JFR: Disabling the JfrThreadSampler commits only a partially disabled state
  • 8bf03b9: 8320363: ppc64 TypeEntries::type_unknown logic looks wrong, missed optimization opportunity
  • bf0fb69: 8320885: Bump update version for OpenJDK: jdk-17.0.11
  • 9165f77: 8271566: DSA signature length value is not accurate in P11Signature
  • cd52f99: 8275509: ModuleDescriptor.hashCode isn't reproducible across builds
  • ... and 17 more: https://git.openjdk.org/jdk17u-dev/compare/c7fb6ea7eb41bac13bc58151c63926934c0c25cd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 4, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 4, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

Going to push as commit 2a019da.
Since your change was applied there have been 35 commits pushed to the master branch:

  • ce670b6: 8318951: Additional negative value check in JPEG decoding
  • 822c496: 8316030: Update Libpng to 1.6.40
  • 9c643df: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 6a9a5ef: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • be33d68: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler
  • 8248b0c: 8302149: Speed up compiler/jsr292/methodHandleExceptions/TestAMEnotNPE.java
  • a9c5a5e: 8292946: GC lock/jni/jnilock001 test failed "assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed()) failed: Twice in a row"
  • bea6780: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • e4cb6aa: 8287832: jdk/jfr/event/runtime/TestActiveSettingEvent.java failed with "Expected two batches of Active Setting events"
  • 56fc06c: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)
  • ... and 25 more: https://git.openjdk.org/jdk17u-dev/compare/c7fb6ea7eb41bac13bc58151c63926934c0c25cd...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2023
@openjdk openjdk bot closed this Dec 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@GoeLin Pushed as commit 2a019da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant