Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout #2009

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 30, 2023

I backport this because we see it failing in our CI.


Progress

  • JDK-8269258 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2009/head:pull/2009
$ git checkout pull/2009

Update a local copy of the PR:
$ git checkout pull/2009
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2009/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2009

View PR using the GUI difftool:
$ git pr show -t 2009

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2009.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 37921e30803449c06b4d542fdfeed9928cce8a7d 8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout Nov 30, 2023
@openjdk
Copy link

openjdk bot commented Nov 30, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 30, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2023
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2023

Webrevs

@openjdk openjdk bot added the approval label Dec 1, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269258: java/net/httpclient/ManyRequestsLegacy.java failed with connection timeout

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e4cb6aa: 8287832: jdk/jfr/event/runtime/TestActiveSettingEvent.java failed with "Expected two batches of Active Setting events"
  • 56fc06c: 8317603: Improve exception messages thrown by sun.nio.ch.Net native methods (win)

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 4, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 4, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 4, 2023

Going to push as commit a028120.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 2a019da: 8301846: Invalid TargetDataLine after screen lock when using JFileChooser or COM library
  • ce670b6: 8318951: Additional negative value check in JPEG decoding
  • 822c496: 8316030: Update Libpng to 1.6.40
  • 9c643df: 8316418: containers/docker/TestMemoryWithCgroupV1.java get OOM killed with Parallel GC
  • 6a9a5ef: 8308043: Deadlock in TestCSLocker.java due to blocking GC while allocating
  • be33d68: 8298087: XML Schema Validation reports an required attribute twice via ErrorHandler
  • 8248b0c: 8302149: Speed up compiler/jsr292/methodHandleExceptions/TestAMEnotNPE.java
  • a9c5a5e: 8292946: GC lock/jni/jnilock001 test failed "assert(gch->gc_cause() == GCCause::_scavenge_alot || !gch->incremental_collection_failed()) failed: Twice in a row"
  • bea6780: 8289764: gc/lock tests failed with "OutOfMemoryError: Java heap space: failed reallocation of scalar replaced objects"
  • e4cb6aa: 8287832: jdk/jfr/event/runtime/TestActiveSettingEvent.java failed with "Expected two batches of Active Setting events"
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/28e1a33856504abfc003a283ece928fb87f6623c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 4, 2023
@openjdk openjdk bot closed this Dec 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@GoeLin Pushed as commit a028120.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant