Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301306: java/net/httpclient/* fail with -Xcomp #2011

Closed
wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 4, 2023

I backport this because we see issues with these tests in our CI.

HttpClientLocalAddrTest.java and HttpALot.java are not in 17, skipped.

SpecialHeadersTest.java resolved due to context.

I also include follow-up 8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306
to avoid the test to fail.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8301787 needs maintainer approval
  • JDK-8301306 needs maintainer approval

Issues

  • JDK-8301306: java/net/httpclient/* fail with -Xcomp (Bug - P4 - Approved)
  • JDK-8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2011/head:pull/2011
$ git checkout pull/2011

Update a local copy of the PR:
$ git checkout pull/2011
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2011/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2011

View PR using the GUI difftool:
$ git pr show -t 2011

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2011.diff

Webrev

Link to Webrev Comment

@GoeLin
Copy link
Member Author

GoeLin commented Dec 4, 2023

/issue 8301787

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 4, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6f9106e0d0d9f082f0a61009f95d1b8663dd8d4f 8301306: java/net/httpclient/* fail with -Xcomp Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 4, 2023
@openjdk
Copy link

openjdk bot commented Dec 4, 2023

@GoeLin
Adding additional issue to issue list: 8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306.

@mlbridge
Copy link

mlbridge bot commented Dec 4, 2023

Webrevs

Copy link

@RealLucy RealLucy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Dec 5, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the approval label Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301306: java/net/httpclient/* fail with -Xcomp
8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306

Reviewed-by: lucy

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • f8f733d: Merge
  • b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 6, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 6, 2023

Going to push as commit be72703.
Since your change was applied there have been 2 commits pushed to the master branch:

  • f8f733d: Merge
  • b78a848: 8320601: ProblemList java/lang/invoke/lambda/LambdaFileEncodingSerialization.java on linux-all

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 6, 2023
@openjdk openjdk bot closed this Dec 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 6, 2023
@openjdk
Copy link

openjdk bot commented Dec 6, 2023

@GoeLin Pushed as commit be72703.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8301306 branch December 6, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants