-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8301306: java/net/httpclient/* fail with -Xcomp #2011
Conversation
/issue 8301787 |
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@GoeLin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
|
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
I backport this because we see issues with these tests in our CI.
HttpClientLocalAddrTest.java and HttpALot.java are not in 17, skipped.
SpecialHeadersTest.java resolved due to context.
I also include follow-up 8301787: java/net/httpclient/SpecialHeadersTest failing after JDK-8301306
to avoid the test to fail.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2011/head:pull/2011
$ git checkout pull/2011
Update a local copy of the PR:
$ git checkout pull/2011
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2011/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2011
View PR using the GUI difftool:
$ git pr show -t 2011
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2011.diff
Webrev
Link to Webrev Comment