Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314220: Configurable InlineCacheBuffer size #2015

Closed
wants to merge 1 commit into from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 5, 2023

Unclean backport to allow a tunable for IC buffer size, to avoid excess ICBufferFull safepoints in some workloads.

The backport is not clean for two reasons:

  1. Usual NULL and nullptr context conflict.
  2. % CodeEntryAlignment and % stub_alignment() conflict due to missing JDK-8284578 in JDK 17u. We could backport that one first, as we expect some other backports in this area as well, like JDK-8321137. But it was rejected one time, so I would rather see JDK-8321137 to pan out, and then resolve a little conflict introduced by this change later.

Additional testing:

  • Eyeballing -XX:+TraceICBuffer output on ad-hoc workloads

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314220 needs maintainer approval

Issue

  • JDK-8314220: Configurable InlineCacheBuffer size (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2015/head:pull/2015
$ git checkout pull/2015

Update a local copy of the PR:
$ git checkout pull/2015
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2015/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2015

View PR using the GUI difftool:
$ git pr show -t 2015

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2015.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a40d8d97e84d88d1a65aba81bfc09339be95e427 8314220: Configurable InlineCacheBuffer size Dec 5, 2023
@openjdk
Copy link

openjdk bot commented Dec 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 5, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 5, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 7, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

/approval request Unclean backport to allow a tunable for IC buffer size, to avoid excess ICBufferFull safepoints in some workloads.

@openjdk
Copy link

openjdk bot commented Dec 11, 2023

@shipilev
8314220: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 11, 2023
@openjdk
Copy link

openjdk bot commented Dec 15, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314220: Configurable InlineCacheBuffer size

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 33 new commits pushed to the master branch:

  • 969f105: 8302017: Allocate BadPaddingException only if it will be thrown
  • 78839e9: 8054022: HttpURLConnection timeouts with Expect: 100-Continue and no chunking
  • 6493102: 7167356: (javac) investigate failing tests in JavacParserTest
  • 71471c1: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
  • aba80d1: 8274634: Use String.equals instead of String.compareTo in java.desktop
  • 519fd89: 8295124: Atomic::add to pointer type may return wrong value
  • 5bc2302: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result
  • fb950fa: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
  • 3a2bf8e: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • 9596656: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • ... and 23 more: https://git.openjdk.org/jdk17u-dev/compare/a028120220f6fd28e39fe0f6190eb1f5da6a788d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 15, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2023

Going to push as commit 00d74be.
Since your change was applied there have been 47 commits pushed to the master branch:

  • 9a104e0: 8318562: Computational test more than 2x slower when AVX instructions are used
  • 5ed1926: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 7973bfe: 8321215: Incorrect x86 instruction encoding for VSIB addressing mode
  • c555fe3: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch
  • 3809b71: 8293117: Add atomic bitset functions
  • a032136: 8295068: SSLEngine throws NPE parsing CertificateRequests
  • f033de0: 8274632: Possible pointer overflow in PretouchTask chunk claiming
  • c44bd2b: 8320001: javac crashes while adding type annotations to the return type of a constructor
  • 97d8ed2: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
  • 48c8478: 8320798: Console read line with zero out should zero out underlying buffer
  • ... and 37 more: https://git.openjdk.org/jdk17u-dev/compare/a028120220f6fd28e39fe0f6190eb1f5da6a788d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2023
@openjdk openjdk bot closed this Dec 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@shipilev Pushed as commit 00d74be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants