Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure #2029

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Dec 8, 2023

This fixes a small issue on mac.

Skipped change to ProblemList as the test is not listed in 17. Will mark clean.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8294254 needs maintainer approval

Issue

  • JDK-8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2029/head:pull/2029
$ git checkout pull/2029

Update a local copy of the PR:
$ git checkout pull/2029
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2029/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2029

View PR using the GUI difftool:
$ git pr show -t 2029

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2029.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 358ac07255cc640cbcb9b0df5302d97891a34087 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure Dec 8, 2023
@openjdk
Copy link

openjdk bot commented Dec 8, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Dec 8, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 8, 2023

/clean

@openjdk openjdk bot added the clean label Dec 8, 2023
@openjdk
Copy link

openjdk bot commented Dec 8, 2023

@GoeLin This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Dec 8, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@mlbridge
Copy link

mlbridge bot commented Dec 8, 2023

Webrevs

@openjdk openjdk bot added the approval label Dec 9, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 519fd89: 8295124: Atomic::add to pointer type may return wrong value
  • 5bc2302: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result
  • fb950fa: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
  • 3a2bf8e: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • 9596656: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • f8e54a9: 8316929: Shenandoah: Shenandoah degenerated GC and full GC need to cleanup old OopMapCache entries
  • 2f042a4: 8292458: Atomic operations on scoped enums don't build with clang
  • c671447: 8310838: Correct range notations in MethodTypeDesc specification
  • 139f4eb: 8301310: The SendRawSysexMessage test may cause a JVM crash
  • bf2a1d3: 8283994: Make Xerces DatatypeException stackless

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 13, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Dec 13, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 13, 2023

Going to push as commit 71471c1.
Since your change was applied there have been 11 commits pushed to the master branch:

  • aba80d1: 8274634: Use String.equals instead of String.compareTo in java.desktop
  • 519fd89: 8295124: Atomic::add to pointer type may return wrong value
  • 5bc2302: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result
  • fb950fa: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
  • 3a2bf8e: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • 9596656: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • f8e54a9: 8316929: Shenandoah: Shenandoah degenerated GC and full GC need to cleanup old OopMapCache entries
  • 2f042a4: 8292458: Atomic operations on scoped enums don't build with clang
  • c671447: 8310838: Correct range notations in MethodTypeDesc specification
  • 139f4eb: 8301310: The SendRawSysexMessage test may cause a JVM crash
  • ... and 1 more: https://git.openjdk.org/jdk17u-dev/compare/ccb0b549ea7ff92501560c68ce00ff5e96fa78cc...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 13, 2023
@openjdk openjdk bot closed this Dec 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 13, 2023
@openjdk
Copy link

openjdk bot commented Dec 13, 2023

@GoeLin Pushed as commit 71471c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8294254 branch February 1, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant