Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293165: GHA: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java #2030

Closed
wants to merge 1 commit into from

Conversation

ashu-mehra
Copy link

@ashu-mehra ashu-mehra commented Dec 8, 2023

Although not clean but a trivial backport.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8293165 needs maintainer approval

Integration blocker

 ⚠️ Dependency #2021 must be integrated first

Issue

  • JDK-8293165: GHA: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2030/head:pull/2030
$ git checkout pull/2030

Update a local copy of the PR:
$ git checkout pull/2030
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2030/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2030

View PR using the GUI difftool:
$ git pr show -t 2030

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2030.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2023

👋 Welcome back asmehra! A progress list of the required criteria for merging this PR into pr/2021 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2023

Webrevs

@ashu-mehra ashu-mehra changed the title 8293165: GHA: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java Backport 372fc58e897d25713db0dfe289ed25c40d9a3985 Dec 12, 2023
@openjdk openjdk bot changed the title Backport 372fc58e897d25713db0dfe289ed25c40d9a3985 8293165: GHA: Provide necessary x86_32 packages for runtime/ErrorHandling/TestDwarf.java Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 12, 2023
Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But, it looks like the linux-x86 GHA failure may be related to this change.

@ashu-mehra
Copy link
Author

But, it looks like the linux-x86 GHA failure may be related to this change.

The failure is same as seen in the parent issue #2021 which is a backport of JDK-8232181. Looking at the related issues in JDK-8232181, I though both JDK-8293165 and JDK-8293201 are needed to fix it, which is why I backported both. But looks like JDK-8242181 is sufficient to fix the GHA failure, and this backport for JDK-8293165 is not really needed.

I am closing this PR for now.

@ashu-mehra ashu-mehra closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants