8273454: C2: Transform (-a)*(-b) into a*b

[GoeLin]

I backport this for parity with 17.0.11-oracle.

This contains follow up fix 8274060: C2: Incorrect computation after JDK-8273454 and a part of JDK-8274130) C2: MulNode::Ideal chained transformations may act on wrong nodes which is already backported, but omitted the part to be applied to this patch.
This is also the reason why a clean backport failed.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8273454 needs maintainer approval
• Change must not contain extraneous whitespace
• JDK-8274060 needs maintainer approval
• Commit message must refer to an issue

Issues

• JDK-8273454: C2: Transform (-a)(-b) into ab (Enhancement - P4 - Approved)
• JDK-8274060: C2: Incorrect computation after JDK-8273454 (Bug - P1 - Approved)

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2035/head:pull/2035
$ git checkout pull/2035

Update a local copy of the PR:
$ git checkout pull/2035
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2035/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2035

View PR using the GUI difftool:
$ git pr show -t 2035

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2035.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 03: Full - Incremental (2dab157f)
• 02: Full - Incremental (1a7414e9)
• 01: Full - Incremental (286a84dd)
• 00: Full (1a7414e9)

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[openjdk]

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

[shipilev]

I never thought we would backport this. But now that we do, this hunk is missing:
openjdk/jdk@756d22c#diff-b1bd52f0743843e15452764f48ff43c15dd3192a28bfb684b34149f0e964996eR83-R84

When we backported JDK-8274130, we skipped that hunk.

[GoeLin]

/issue 8274060

[openjdk]

@GoeLin
Adding additional issue to issue list: 8274060: C2: Incorrect computation after JDK-8273454.

[GoeLin]

Thanks for catching this! I thought I had added that part :/

[shipilev]

Yeah, this looks right.

[openjdk]

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273454: C2: Transform (-a)*(-b) into a*b
8274060: C2: Incorrect computation after JDK-8273454

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• 969f105: 8302017: Allocate BadPaddingException only if it will be thrown
• 78839e9: 8054022: HttpURLConnection timeouts with Expect: 100-Continue and no chunking
• 6493102: 7167356: (javac) investigate failing tests in JavacParserTest
• 71471c1: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
• aba80d1: 8274634: Use String.equals instead of String.compareTo in java.desktop
• 519fd89: 8295124: Atomic::add to pointer type may return wrong value
• 5bc2302: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result
• fb950fa: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
• 3a2bf8e: 8225377: type annotations are not visible to javac plugins across compilation boundaries
• 9596656: 8271118: C2: StressGCM should have higher priority than frequency-based policy
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/c67144742b6f4777da941f5158021884b7ea7768...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[GoeLin]

/integrate

[openjdk]

Going to push as commit 873148e.
Since your change was applied there have been 12 commits pushed to the master branch:

• 969f105: 8302017: Allocate BadPaddingException only if it will be thrown
• 78839e9: 8054022: HttpURLConnection timeouts with Expect: 100-Continue and no chunking
• 6493102: 7167356: (javac) investigate failing tests in JavacParserTest
• 71471c1: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
• aba80d1: 8274634: Use String.equals instead of String.compareTo in java.desktop
• 519fd89: 8295124: Atomic::add to pointer type may return wrong value
• 5bc2302: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result
• fb950fa: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
• 3a2bf8e: 8225377: type annotations are not visible to javac plugins across compilation boundaries
• 9596656: 8271118: C2: StressGCM should have higher priority than frequency-based policy
• ... and 2 more: https://git.openjdk.org/jdk17u-dev/compare/c67144742b6f4777da941f5158021884b7ea7768...master

Your commit was automatically rebased without conflicts.

[openjdk]

@GoeLin Pushed as commit 873148e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.