Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316929: Shenandoah: Shenandoah degenerated GC and full GC need to cleanup old OopMapCache entries #2037

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 11, 2023

Clean backport to eliminate Shenandoah memory leak.

Additional testing:

  • macos-aarch64-server-fastdebug, hotspot_gc_shenandoah

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316929 needs maintainer approval

Issue

  • JDK-8316929: Shenandoah: Shenandoah degenerated GC and full GC need to cleanup old OopMapCache entries (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2037/head:pull/2037
$ git checkout pull/2037

Update a local copy of the PR:
$ git checkout pull/2037
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2037/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2037

View PR using the GUI difftool:
$ git pr show -t 2037

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2037.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 11, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e25121d1d908bd74e7a5914d85284ab322bed1a3 8316929: Shenandoah: Shenandoah degenerated GC and full GC need to cleanup old OopMapCache entries Dec 11, 2023
@openjdk
Copy link

openjdk bot commented Dec 11, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 11, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 11, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 11, 2023

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to eliminate Shenandoah memory leak. Applies cleanly. Testing passes. Other GCs do the same thing.

@openjdk
Copy link

openjdk bot commented Dec 11, 2023

@shipilev
8316929: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 11, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316929: Shenandoah: Shenandoah degenerated GC and full GC need to cleanup old OopMapCache entries

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2f042a4: 8292458: Atomic operations on scoped enums don't build with clang

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 12, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

Going to push as commit f8e54a9.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 2f042a4: 8292458: Atomic operations on scoped enums don't build with clang

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2023
@openjdk openjdk bot closed this Dec 12, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@shipilev Pushed as commit f8e54a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant