Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273056: java.util.random does not correctly sample exponential or Gaussian distributions #204

Closed
wants to merge 1 commit into from

Conversation

lutkerd
Copy link
Contributor

@lutkerd lutkerd commented Mar 7, 2022

Clean backport of 8273056: java.util.random does not correctly sample exponential or Gaussian distributions


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8273056: java.util.random does not correctly sample exponential or Gaussian distributions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk17u-dev pull/204/head:pull/204
$ git checkout pull/204

Update a local copy of the PR:
$ git checkout pull/204
$ git pull https://git.openjdk.java.net/jdk17u-dev pull/204/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 204

View PR using the GUI difftool:
$ git pr show -t 204

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk17u-dev/pull/204.diff

…ussian distributions

Co-authored-by: Guy Steele <gls@openjdk.org>
Reviewed-by: bpb, darcy
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 7, 2022

👋 Welcome back lutkerd! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@lutkerd
Copy link
Contributor Author

lutkerd commented Mar 7, 2022

Same as #199 but with a branch and correct title as per @TheRealMDoerr's comments.

@openjdk openjdk bot changed the title Backport 3d98ec1b7bc77237177ecfc069c0e9a7e75829bc 8273056: java.util.random does not correctly sample exponential or Gaussian distributions Mar 7, 2022
@openjdk
Copy link

openjdk bot commented Mar 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Mar 7, 2022

⚠️ @lutkerd the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout 8273056
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Mar 7, 2022

@lutkerd This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8273056: java.util.random does not correctly sample exponential or Gaussian distributions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

  • e2103de: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations
  • 91e9344: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed
  • ec2c521: 8278796: Incorrect behavior of FloatVector.withLane on X86
  • b3aa42d: 8278014: [vectorapi] Remove test run script
  • 47723c2: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • 1fc280c: 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN
  • 3aa5b51: 8273804: Platform.isTieredSupported should handle the no-compiler case

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 7, 2022
@mlbridge
Copy link

mlbridge bot commented Mar 7, 2022

Webrevs

@Pr0methean
Copy link

Pr0methean commented Mar 8, 2022

/sponsor

@Pr0methean
Copy link

Pr0methean commented Mar 8, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 8, 2022

@Pr0methean Only Committers are allowed to sponsor changes.

@openjdk
Copy link

openjdk bot commented Mar 8, 2022

@Pr0methean Only the author (@lutkerd) is allowed to issue the integrate command.

@GoeLin
Copy link
Member

GoeLin commented Mar 8, 2022

Hi @Pr0methean @lutkerd
please make yourself familiar with the OpenJDK and jdk11u upedates project rules.
You might want to start reading here: https://wiki.openjdk.java.net/display/JDKUpdates/How+to+contribute+a+fix

@lutkerd
Copy link
Contributor Author

lutkerd commented Mar 8, 2022

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Mar 8, 2022
@openjdk
Copy link

openjdk bot commented Mar 8, 2022

@lutkerd
Your change (at version 144ec8b) is now ready to be sponsored by a Committer.

@TheRealMDoerr
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Mar 8, 2022

Going to push as commit ff1ef50.
Since your change was applied there have been 7 commits pushed to the master branch:

  • e2103de: 8276990: Memory leak in invoker.c fillInvokeRequest() during JDI operations
  • 91e9344: 8274855: vectorapi tests failing with assert(!vbox->is_Phi()) failed
  • ec2c521: 8278796: Incorrect behavior of FloatVector.withLane on X86
  • b3aa42d: 8278014: [vectorapi] Remove test run script
  • 47723c2: 8275830: C2: Receiver downcast is missing when inlining through method handle linkers
  • 1fc280c: 8280123: C2: Infinite loop in CMoveINode::Ideal during IGVN
  • 3aa5b51: 8273804: Platform.isTieredSupported should handle the no-compiler case

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 8, 2022
@openjdk openjdk bot closed this Mar 8, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Mar 8, 2022
@openjdk
Copy link

openjdk bot commented Mar 8, 2022

@TheRealMDoerr @lutkerd Pushed as commit ff1ef50.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
5 participants