Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8295068: SSLEngine throws NPE parsing CertificateRequests #2046

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 12, 2023

Clean backport to resolve a corner case in certificate handling.

Additional testing:

  • macos-aarch64-server-fastdebug, jdk_security

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8295068 needs maintainer approval

Issue

  • JDK-8295068: SSLEngine throws NPE parsing CertificateRequests (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2046/head:pull/2046
$ git checkout pull/2046

Update a local copy of the PR:
$ git checkout pull/2046
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2046/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2046

View PR using the GUI difftool:
$ git pr show -t 2046

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2046.diff

Webrev

Link to Webrev Comment

@shipilev
Copy link
Member Author

/approval request Clean backport to resolve a corner case in certificate handling. Applies cleanly. Testing passes.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5667afc36275b064c7700518f453fe8657e13636 8295068: SSLEngine throws NPE parsing CertificateRequests Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 12, 2023

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@shipilev
8295068: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 12, 2023
@mlbridge
Copy link

mlbridge bot commented Dec 12, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 14, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8295068: SSLEngine throws NPE parsing CertificateRequests

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 78839e9: 8054022: HttpURLConnection timeouts with Expect: 100-Continue and no chunking
  • 6493102: 7167356: (javac) investigate failing tests in JavacParserTest
  • 71471c1: 8294254: [macOS] javax/swing/plaf/aqua/CustomComboBoxFocusTest.java failure
  • aba80d1: 8274634: Use String.equals instead of String.compareTo in java.desktop
  • 519fd89: 8295124: Atomic::add to pointer type may return wrong value
  • 5bc2302: 8271616: oddPart in MutableBigInteger::mutableModInverse contains info on final result
  • fb950fa: 8316415: Parallelize sun/security/rsa/SignedObjectChain.java subtests
  • 3a2bf8e: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • 9596656: 8271118: C2: StressGCM should have higher priority than frequency-based policy
  • f8e54a9: 8316929: Shenandoah: Shenandoah degenerated GC and full GC need to cleanup old OopMapCache entries

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Dec 14, 2023
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Dec 19, 2023

Going to push as commit a032136.
Since your change was applied there have been 19 commits pushed to the master branch:

  • f033de0: 8274632: Possible pointer overflow in PretouchTask chunk claiming
  • c44bd2b: 8320001: javac crashes while adding type annotations to the return type of a constructor
  • 97d8ed2: 8309733: [macOS, Accessibility] VoiceOver: Incorrect announcements of JRadioButton
  • 48c8478: 8320798: Console read line with zero out should zero out underlying buffer
  • 5653d2d: 8320597: RSA signature verification fails on signed data that does not encode params correctly
  • dcba538: 8283400: [macos] a11y : Screen magnifier does not reflect JRadioButton value change
  • 5fe2d51: 8297968: Crash in PrintOptoAssembly
  • 873148e: 8273454: C2: Transform (-a)(-b) into ab
  • 969f105: 8302017: Allocate BadPaddingException only if it will be thrown
  • 78839e9: 8054022: HttpURLConnection timeouts with Expect: 100-Continue and no chunking
  • ... and 9 more: https://git.openjdk.org/jdk17u-dev/compare/2f042a4d4eb06a68a91d10d8f86cee61c41e461f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 19, 2023
@openjdk openjdk bot closed this Dec 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 19, 2023
@openjdk
Copy link

openjdk bot commented Dec 19, 2023

@shipilev Pushed as commit a032136.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant