8205076: [17u] Inet6AddressImpl.c: lookupIfLocalHost accesses int InetAddress.preferIPv6Address as a boolean

[shipilev]

This is a 11u and 17u -specific bug, see JBS and its comments for more details. I think we can fix this by explicitly checking against the PREFER_IPV6_VALUE, like post JDK 18 code does.

Additional testing:

• macos-aarch64-server-fastdebug, DcmdMBeanTestCheckJni.java now passes
• macos-aarch64-server-fastdebug, jdk_net

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8205076 needs maintainer approval

Issue

• JDK-8205076: [17u] Inet6AddressImpl.c: lookupIfLocalHost accesses int InetAddress.preferIPv6Address as a boolean (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2048/head:pull/2048
$ git checkout pull/2048

Update a local copy of the PR:
$ git checkout pull/2048
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2048/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2048

View PR using the GUI difftool:
$ git pr show -t 2048

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2048.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[mlbridge]

Webrevs

• 01: Full - Incremental (841b6fb6)
• 00: Full (fa0cd6b8)

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[shipilev]

/approval request 17u-specific fix, does what upstream code already do post JDK 18. Testing passes on platform where tests used to fail.

[openjdk]

@shipilev
8205076: The approval request has been created successfully.

[GoeLin]

Good catch!

[GoeLin]

/approve yes

[openjdk]

@GoeLin
8205076: The approval request has been approved.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8205076: [17u] Inet6AddressImpl.c: `lookupIfLocalHost` accesses `int InetAddress.preferIPv6Address` as a boolean

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 43d15d1: 8307926: Support byte-sized atomic bitset operations

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Thanks!

/integrate

[openjdk]

Going to push as commit 3eb15b0.
Since your change was applied there have been 4 commits pushed to the master branch:

• 2a0d0ac: 8318183: C2: VM may crash after hitting node limit
• 53211e0: 8318961: increase javacserver connection timeout values and max retry attempts
• 5d86e19: 8320937: support latest VS2022 MSC_VER in abstract_vm_version.cpp
• 43d15d1: 8307926: Support byte-sized atomic bitset operations

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 3eb15b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.