-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8205076: [17u] Inet6AddressImpl.c: lookupIfLocalHost
accesses int InetAddress.preferIPv6Address
as a boolean
#2048
8205076: [17u] Inet6AddressImpl.c: lookupIfLocalHost
accesses int InetAddress.preferIPv6Address
as a boolean
#2048
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
Webrevs
|
|
/approval request 17u-specific fix, does what upstream code already do post JDK 18. Testing passes on platform where tests used to fail. |
Good catch! |
/approve yes |
@GoeLin |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks! /integrate |
Going to push as commit 3eb15b0.
Your commit was automatically rebased without conflicts. |
This is a 11u and 17u -specific bug, see JBS and its comments for more details. I think we can fix this by explicitly checking against the
PREFER_IPV6_VALUE
, like post JDK 18 code does.Additional testing:
DcmdMBeanTestCheckJni.java
now passesjdk_net
Progress
Issue
lookupIfLocalHost
accessesint InetAddress.preferIPv6Address
as a boolean (Bug - P4 - Approved)Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/2048/head:pull/2048
$ git checkout pull/2048
Update a local copy of the PR:
$ git checkout pull/2048
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/2048/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 2048
View PR using the GUI difftool:
$ git pr show -t 2048
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/2048.diff
Webrev
Link to Webrev Comment